From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933379AbcFOUZi (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jun 2016 16:25:38 -0400
Received: from mail-lf0-f45.google.com ([209.85.215.45]:34221 "EHLO
	mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753055AbcFOUZf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jun 2016 16:25:35 -0400
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, Yang Shi <yang.shi@linaro.org>,
        Ingo Molnar <mingo@kernel.org>, Mel Gorman <mgorman@suse.de>,
        Kees Cook <keescook@chromium.org>,
        Yaowei Bai <baiyaowei@cmss.chinamobile.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>
Subject: Re: [PATCH] init, allow blacklisting of module_init functions
Organization: D03
References: <1466004652-27206-1-git-send-email-prarit@redhat.com>
X-Hashcash: 1:20:160615:akpm@linux-foundation.org::lEWyHKlHp7Sbe0IQ:0000000000000000000000000000000000000rfS
X-Hashcash: 1:20:160615:keescook@chromium.org::G69sbAMSx2CwKe09:00000000000000000000000000000000000000000x14
X-Hashcash: 1:20:160615:linux-kernel@vger.kernel.org::BSDhdOuzvRbvzHgV:0000000000000000000000000000000001uPX
X-Hashcash: 1:20:160615:prarit@redhat.com::ZMOTDtp7IxDnB7RX:0000000000000000000000000000000000000000000027AD
X-Hashcash: 1:20:160615:aryabinin@virtuozzo.com::8jNLXvPYAHuipahx:0000000000000000000000000000000000000031Kz
X-Hashcash: 1:20:160615:yang.shi@linaro.org::u0J4uZB0CifwQd/S:00000000000000000000000000000000000000000042Hb
X-Hashcash: 1:20:160615:mgorman@suse.de::gpi4L8xpPbAYQCd/:004gid
X-Hashcash: 1:20:160615:baiyaowei@cmss.chinamobile.com::sg3xL3sE4L9yCefV:00000000000000000000000000000003/Ah
X-Hashcash: 1:20:160615:tglx@linutronix.de::hUvR6e3k9l46ekZs:00000000000000000000000000000000000000000005vzo
X-Hashcash: 1:20:160615:mingo@kernel.org::BO0T5vZje8M384U+:075Yh
Date: Wed, 15 Jun 2016 22:25:31 +0200
In-Reply-To: <1466004652-27206-1-git-send-email-prarit@redhat.com> (Prarit
	Bhargava's message of "Wed, 15 Jun 2016 11:30:52 -0400")
Message-ID: <87poridwsk.fsf@rasmusvillemoes.dk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 15 2016, Prarit Bhargava <prarit@redhat.com> wrote:

> At some point I was 100% sure this worked.  I do remember testing it against
> just a loadable module and had positive testing results.

I think the current %ps/%pf behaviour was introduced in 4796dd200db9
(way back in 2012). 

> In any case this is a trivial patch to add the functionality...

Which I still think is broken and needlessly complicated. Please read my
first reply again.

Rasmus