From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759026AbYEPXZh (ORCPT ); Fri, 16 May 2008 19:25:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751844AbYEPXZ0 (ORCPT ); Fri, 16 May 2008 19:25:26 -0400 Received: from mail.parknet.ad.jp ([210.171.162.6]:57697 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615AbYEPXZZ (ORCPT ); Fri, 16 May 2008 19:25:25 -0400 From: OGAWA Hirofumi To: Miklos Szeredi Cc: akpm@linux-foundation.org, hch@infradead.org, viro@ZenIV.linux.org.uk, ezk@cs.sunysb.edu, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 07/22] fat: dont call notify_change References: <20080516163136.560107038@szeredi.hu> <20080516163222.235825996@szeredi.hu> Date: Sat, 17 May 2008 08:25:15 +0900 In-Reply-To: <20080516163222.235825996@szeredi.hu> (Miklos Szeredi's message of "Fri, 16 May 2008 18:31:43 +0200") Message-ID: <87prrl7rxg.fsf@duaron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Anti-Virus: Kaspersky Anti-Virus for MailServers 5.5.10/RELEASE, bases: 24052007 #308098, status: clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miklos Szeredi writes: > From: Miklos Szeredi > > The FAT_IOCTL_SET_ATTRIBUTES ioctl() calls notify_change() to change > the file mode before changing the inode attributes. Replace with > explicit calls to security_inode_setattr(), fat_setattr() and > fsnotify_change(). > > This is equivalent to the original. The reason it is needed, is that > later in the series we move the immutable check into notify_change(). > That would break the FAT_IOCTL_SET_ATTRIBUTES ioctl, as it needs to > perform the mode change regardless of the immutability of the file. > > Signed-off-by: Miklos Szeredi > CC: OGAWA Hirofumi Don't we need to add EXPORT_SYMBOL(security_inode_setattr)? Otherwise, looks good to me. Acked-by: OGAWA Hirofumi Thanks. -- OGAWA Hirofumi