From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Olof Johansson <olof@lixom.net>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fat: silence warning for 64KB PAGE_SIZE builds
Date: Wed, 07 Nov 2007 23:39:01 +0900 [thread overview]
Message-ID: <87prymqfwa.fsf@duaron.myhome.or.jp> (raw)
In-Reply-To: <20071107051540.GB24266@lixom.net> (Olof Johansson's message of "Tue, 6 Nov 2007 23:15:40 -0600")
Olof Johansson <olof@lixom.net> writes:
> logical_sector_size can never be more than 16 bits worth, but switching
> it to an int silences gcc. It's a sanity check that can never fail with
> 64KB PAGE_SIZE but it seems like it'd still be useful for other page
> sizes, so it's worth keeping:
>
> if (!is_power_of_2(logical_sector_size)
> || (logical_sector_size < 512)
> || (PAGE_CACHE_SIZE < logical_sector_size)) {
> if (!silent)
> printk(KERN_ERR "FAT: bogus logical sector size %u\n",
> logical_sector_size);
> brelse(bh);
> goto out_invalid;
> }
Please use 4096 instead of allowing it, at least for now.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2007-11-07 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 5:15 Olof Johansson
2007-11-07 14:39 ` OGAWA Hirofumi [this message]
2007-11-07 15:01 ` Olof Johansson
2007-11-07 15:02 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prymqfwa.fsf@duaron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®