mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nix <nix@esperi.org.uk>
To: linux-kernel@vger.kernel.org
Cc: kai@germaschewski.name, Sam Ravnborg <sam@ravnborg.org>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH] Fix 100% initramfs bloat in 2.6.17 versus 2.6.16
Date: Wed, 21 Jun 2006 00:15:17 +0100	[thread overview]
Message-ID: <87psh3mnay.fsf@hades.wkstn.nix> (raw)

When I built 2.6.17 for the first time I was a little surprised to see
my kernel putting on >500Kb in weight.

It didn't take long to work out that this was because my initramfs's
contents were being included twice in the cpio image.

A make V=1 makes the problem obvious:

/bin/sh /usr/packages/linux/versions/i686-loki/scripts/gen_initramfs_list.sh -l  "usr/initramfs" > usr/.initramfs_data.cpio.gz.d
  /bin/sh /usr/packages/linux/versions/i686-loki/scripts/gen_initramfs_list.sh -o usr/initramfs_data.cpio.gz  -u 0  -g 0  "usr/initramfs"  "usr/initramfs"

Note that doubling-up of the "usr/initramfs", which leads to
gen_initramfs_list.sh dumping the thing into the cpio archive twice.

The cause is an obvious pasto, fixed thusly:

Signed-off-by: Nick Alcock <nix@esperi.org.uk>

diff -durN linux-orig/usr/Makefile linux/usr/Makefile
--- linux-orig/usr/Makefile	2006-06-21 00:07:10.000000000 +0100
+++ linux/usr/Makefile	2006-06-21 00:09:29.000000000 +0100
@@ -33,7 +33,7 @@
 endif
 
 quiet_cmd_initfs = GEN     $@
-      cmd_initfs = $(initramfs) -o $@ $(ramfs-args) $(ramfs-input)
+      cmd_initfs = $(initramfs) -o $@ $(ramfs-args)
 
 targets := initramfs_data.cpio.gz
 $(deps_initramfs): klibcdirs

-- 
`NB: Anyone suggesting that we should say "Tibibytes" instead of
 Terabytes there will be hunted down and brutally slain.
 That is all.' --- Matthew Wilcox

             reply	other threads:[~2006-06-20 23:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-20 23:15 Nix [this message]
2006-06-26 17:57 ` Nix
2006-06-26 20:01   ` Sam Ravnborg
2006-06-27  8:11     ` Nix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87psh3mnay.fsf@hades.wkstn.nix \
    --to=nix@esperi.org.uk \
    --cc=hpa@zytor.com \
    --cc=kai@germaschewski.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®