mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] FAT: rewrite the cache for file allocation table lookup (2/4)
Date: Sun, 05 Sep 2004 21:50:38 +0900	[thread overview]
Message-ID: <87pt50vq01.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20040905123959.A29612@infradead.org> (Christoph Hellwig's message of "Sun, 5 Sep 2004 12:39:59 +0100")

Christoph Hellwig <hch@infradead.org> writes:

>> +#if 0
>> +#define debug_pr(fmt, args...)	printk(fmt, ##args)
>> +#else
>> +#define debug_pr(fmt, args...)
>> +#endif
>
> We have a pr_debug() in <linux/kernel.h> that you could use.

I hated KERN_DEBUG. But, well, maybe pr_debug() was enough...

I'll replace it for now, and will delete it after public test in
Andrew's tree.

>> +static inline int fat_max_cache(struct inode *inode)
>> +{
>> +	return FAT_MAX_CACHE;
>> +}
>
> Do you plan to have per-inode caches later?  This seems rather useless
> otherwise.

This cache is already per-inode.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2004-09-05 12:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-05 11:30 OGAWA Hirofumi
2004-09-05 11:39 ` Christoph Hellwig
2004-09-05 12:50   ` OGAWA Hirofumi [this message]
2004-09-05 14:35     ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pt50vq01.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®