From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: pcm: Use pcm_lib_apply_appl_ptr() in x32 sync_ptr
Date: Fri, 27 Mar 2026 12:39:02 +0100 [thread overview]
Message-ID: <87qzp5qz6x.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260321-alsa-pcm-x32-sync-ptr-v1-1-02ce655657c6@gmail.com>
On Sun, 22 Mar 2026 00:02:21 +0100,
Cássio Gabriel wrote:
>
> snd_pcm_ioctl_sync_ptr_x32() still handles incoming appl_ptr updates
> differently from the other SYNC_PTR paths. The native handler and the
> 32-bit compat handler both pass appl_ptr through pcm_lib_apply_appl_ptr(),
> but the x32 handler still writes control->appl_ptr directly.
>
> That direct assignment skips the common appl_ptr validation against
> runtime->boundary and also bypasses the substream ack() callback.
> This makes the x32 ioctl path behave differently from the native and
> compat32 cases, and it can miss the driver notification that explicit
> appl_ptr synchronization relies on.
>
> Use pcm_lib_apply_appl_ptr() for x32 too, so appl_ptr updates are
> validated consistently and drivers relying on ack() notifications
> see the same behavior.
>
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Thanks, applied to for-next branch now.
Takashi
prev parent reply other threads:[~2026-03-27 11:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-21 23:02 Cássio Gabriel
2026-03-27 11:39 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzp5qz6x.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®