mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Sean Rhodes <sean@starlabs.systems>
Cc: linux-kernel@vger.kernel.org, tiwai@suse.com, perex@perex.cz,
	sbinding@opensource.cirrus.com, kailang@realtek.com,
	chris.chiu@canonical.com, edip@medip.dev,
	linux-sound@vger.kernel.org
Subject: Re: [PATCH v3] ALSA: hda/realtek: Fix speaker pop on Star Labs StarFighter
Date: Wed, 18 Feb 2026 15:02:09 +0100	[thread overview]
Message-ID: <87qzqirvz2.wl-tiwai@suse.de> (raw)
In-Reply-To: <CABtds-3xYN0OEOGfyaBL-N4KBjXZuMnKT+E3FsfoMwt8aReYsg@mail.gmail.com>

On Wed, 18 Feb 2026 10:45:21 +0100,
Sean Rhodes wrote:
> 
> From 4929cc45c32e30361c7e35f0581c83a08fd29b88 Mon Sep 17 00:00:00 2001
> From: Sean Rhodes <sean@starlabs.systems>
> Date: Tue, 17 Feb 2026 11:53:41 +0000
> Subject: [PATCH] ALSA: hda/realtek: Fix speaker pop on Star Labs StarFighter
> 
> On Star Labs StarFighter (Realtek ALC233/235), the internal speakers can
> emit an audible pop when entering or leaving runtime suspend.
> 
> Mute the speaker output paths via snd_hda_gen_shutup_speakers() in the
> Realtek shutup callback before the codec is powered down.
> 
> This is enough to avoid the pop without special EAPD handling.
> 
> Test results:
> - runtime PM pop fixed
> - still reaches D3 (PCI 0000:00:1f.3 power_state=D3hot)
> - does not address pops on cold boot (G3 exit) or around display manager
>   start/shutdown
> 
> journalctl -k (boot):
> - snd_hda_codec_alc269 hdaudioC0D0: ALC233: picked fixup for PCI SSID
>   7017:2014
> - snd_hda_codec_alc269 hdaudioC0D0: autoconfig for ALC233: line_outs=1
>   (0x1b/0x0/0x0/0x0/0x0) type:speaker
> 
> Suggested-by: Takashi Iwai <tiwai@suse.com>
> Tested-by: Sean Rhodes <sean@starlabs.systems>
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>

Unfortunately, the patch isn't applicable, likely your mailer folded
the line somehow unexpectedly.  You can try to do git-am on your repo
for checking it.

Please resubmit after you correctly set up the mail.


thanks,

Takashi

  reply	other threads:[~2026-02-18 14:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18  9:45 Sean Rhodes
2026-02-18 14:02 ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-02-18  9:45 Sean Rhodes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87qzqirvz2.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=chris.chiu@canonical.com \
    --cc=edip@medip.dev \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sbinding@opensource.cirrus.com \
    --cc=sean@starlabs.systems \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®