From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.parknet.co.jp (mail.parknet.co.jp [210.171.160.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CA6C149C6F for ; Fri, 28 Nov 2025 03:57:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.171.160.6 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764302279; cv=none; b=imm8bxhUyeV5PVjJseDozR+/U3lsl3WYhrZQaWINkki6dEPjt0Ouvucy1MzN5pLukiwkLQ+tCftJCzffAX6Kit0+iaGsd36yDRAGt3g6jVRYsLkHus0k9KAWgU95lB820SMFOnLej1RuSB3MVPG6iYe0gVWJjGeQ20MNr5LKF0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764302279; c=relaxed/simple; bh=9pSm98dndIM1jPDw04T6EAVde7AD4cXMu1lr4bqtff8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=QpPFolm3TTaG2GENvQ8JOOcP4kSRZtCIELg1CJEnR7+TicDqd3kHdIgWhULOcEP4z/sZzGt3sFIs9LCfbcOZN0ZhqmYE3T6wK9Y8x4N2cQf5KXyJ1NvyHHaoUipDCgXlxe6dh/oU7DdwxQ/cfx5+ZUN3VAgg0cS9g7Y+E2izqvw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mail.parknet.co.jp; spf=pass smtp.mailfrom=parknet.co.jp; dkim=pass (2048-bit key) header.d=parknet.co.jp header.i=@parknet.co.jp header.b=cejkDBvf; dkim=permerror (0-bit key) header.d=parknet.co.jp header.i=@parknet.co.jp header.b=hMvgxqmf; arc=none smtp.client-ip=210.171.160.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mail.parknet.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=parknet.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=parknet.co.jp header.i=@parknet.co.jp header.b="cejkDBvf"; dkim=permerror (0-bit key) header.d=parknet.co.jp header.i=@parknet.co.jp header.b="hMvgxqmf" Received: from ibmpc.myhome.or.jp (server.parknet.ne.jp [210.171.168.39]) by mail.parknet.co.jp (Postfix) with ESMTPSA id EA1B226F765C; Fri, 28 Nov 2025 12:52:10 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=parknet.co.jp; s=20250114; t=1764301931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dKp3wBoRlJ7UbThlm6IuttyKnRXN5lKiPgQisP7ohBA=; b=cejkDBvf2Mt0bJNlMavnKWuolEl3p2R/8qRXBXpyAkJJlJbYqij0niWqy+gs6QStLMGHK/ VrNB1+1NmYBCyaRWG8dhmFrt2KXkWMu2FOXUU1IU1PqAzvyiIVYLsDmpjsJPaiOwwP2D9Q Zxg/9qaQh97s8EACKeR8lObATUSZ6txivsItLgd/BEAJNVfDZBrjqczt0lsqX5Um8o25kx 27qE75HSqhSBvLW8Ngxmu88eBK+WqFKpococ3zSYKWHLUK7u9wvURndZSiYkKEl/j6148W yFjAO0wzszzKtUAOTzU1GGJJ1N09bR6YX/UVfJs+gS0TdgkCuldmcmeS02YAhg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=parknet.co.jp; s=20250114-ed25519; t=1764301931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dKp3wBoRlJ7UbThlm6IuttyKnRXN5lKiPgQisP7ohBA=; b=hMvgxqmfPs0POe4UaCbdJRv0vxuYIGpflv3YjTtPdyCtEe4PBPcwokuRc99OsYoImDx961 YQTFGm6T0v3q77Cg== Received: from devron.myhome.or.jp (foobar@devron.myhome.or.jp [192.168.0.3]) by ibmpc.myhome.or.jp (8.18.1/8.18.1/Debian-7) with ESMTPS id 5AS3q9J6055362 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 28 Nov 2025 12:52:10 +0900 Received: from devron.myhome.or.jp (foobar@localhost [127.0.0.1]) by devron.myhome.or.jp (8.18.1/8.18.1/Debian-7) with ESMTPS id 5AS3q9pt831335 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 28 Nov 2025 12:52:09 +0900 Received: (from hirofumi@localhost) by devron.myhome.or.jp (8.18.1/8.18.1/Submit) id 5AS3q9mO831334; Fri, 28 Nov 2025 12:52:09 +0900 From: OGAWA Hirofumi To: Lalit Shankar Chowdhury Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/fat: Remove unnecessary wrapper fat_max_cache() In-Reply-To: <20251127175431.126516-1-lalitshankarch@gmail.com> References: <20251127175431.126516-1-lalitshankarch@gmail.com> Date: Fri, 28 Nov 2025 12:52:09 +0900 Message-ID: <87qztireza.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Lalit Shankar Chowdhury writes: > fat_max_cache() always returned FAT_MAX_CACHE and did not use the inode > parameter. So, use the FAT_MAX_CACHE constant directly. > > Signed-off-by: Lalit Shankar Chowdhury Looks good. Acked-by: OGAWA Hirofumi > --- > fs/fat/cache.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/fs/fat/cache.c b/fs/fat/cache.c > index 2af424e200b3..630f3056658e 100644 > --- a/fs/fat/cache.c > +++ b/fs/fat/cache.c > @@ -29,11 +29,6 @@ struct fat_cache_id { > int dcluster; > }; > > -static inline int fat_max_cache(struct inode *inode) > -{ > - return FAT_MAX_CACHE; > -} > - > static struct kmem_cache *fat_cache_cachep; > > static void init_once(void *foo) > @@ -145,7 +140,7 @@ static void fat_cache_add(struct inode *inode, struct fat_cache_id *new) > > cache = fat_cache_merge(inode, new); > if (cache == NULL) { > - if (MSDOS_I(inode)->nr_caches < fat_max_cache(inode)) { > + if (MSDOS_I(inode)->nr_caches < FAT_MAX_CACHE) { > MSDOS_I(inode)->nr_caches++; > spin_unlock(&MSDOS_I(inode)->cache_lru_lock); -- OGAWA Hirofumi