From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A31CD229B18 for ; Fri, 27 Jun 2025 07:51:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751010709; cv=none; b=uMi9jIA/n6pq80Ri0OVeTYNAcIWvH2OlNRB+2JZ1J/9fr+erDrNvK2Fm3/HUrkIjKP0iJPv3aG/WpwylEUEKXN6+t4/mJpNWzNV8uV0+fO8KVyaWBj2S+xepbMYl0tvj+07fjKv9I5Z64DBKdlelOl5gNlxHLRNy2nSoProzlwg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751010709; c=relaxed/simple; bh=CmJByLtbVpwLLdyZCpUwCmCAxS6jbpT0as7eKt5fi5w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=K7Ud1rKh4p8W0h8/x68BlqO0UwLcMjiivFcDgWsXWwse0wz7mEUPvb3DJmNGv5JsIygiTFuvWVyCjvZj18cENWxoFmpi2m4mI9fGfE+sLQ3RUKR75XGe/nMx19JF15dLnIvs6OFhN+ShaoHpe6T2VRwgRkFAlk2dkuXkBMMusl0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LmXn5LPi; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LmXn5LPi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751010706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ri0+PoGBbyLJmIsWOHAGRErY0fpNzrIikLK+X0yMjKY=; b=LmXn5LPixTX2Q5OODSmEVTOeZWjytL4+l7tvZAW71QHK1oDx3F4fmtmo1mufgTZewB1RD2 LaUcCrmAhikSSsZnI1SuXQ8welQRm2Zw1NdDijNRa3kImovqkSItpUp6jxLejsvynK1bvr EX9z3Zgq0GbfhjtjxxPqAkSWFrLaxNI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-251-XVmFB4ovODOEuS2_Qp2_xg-1; Fri, 27 Jun 2025 03:51:44 -0400 X-MC-Unique: XVmFB4ovODOEuS2_Qp2_xg-1 X-Mimecast-MFC-AGG-ID: XVmFB4ovODOEuS2_Qp2_xg_1751010704 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-451d5600a54so14645935e9.2 for ; Fri, 27 Jun 2025 00:51:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751010703; x=1751615503; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ri0+PoGBbyLJmIsWOHAGRErY0fpNzrIikLK+X0yMjKY=; b=YodmS9WX2JERP5ThMOPU24OKLpeexoMPSDLN7bJGxX+ibMFCrJbK/1TZ+bHhPwPePD O34MzI7H/6pjzlaZajkmFWjcVKEjX1Ho3wqAjSrU/q7+apbE7XjCz1rBHXrxGcOFS4e7 jAqECiHjbWn99AtRQmkmhoJfmN3yMa0nV5Ai9YgHwMWOeYvmmPs21+rKbZ17jA3lwTUg q7ooNNXaProwoYKUgPwQEtToICvgpEHrFYBEW6TOYiLUWL7vyRQ4PqWIGyl0Y97UcUQK o+ywQNzBasX572xUoi51e4Vmvtk7PbkxH1ZtspeoIJR8hl5DZ/6dt5BpphxrYUASnsji 69nQ== X-Forwarded-Encrypted: i=1; AJvYcCVZttPoNTjCkESk5PBh+0c+WC4fLgK3YpbZfSt9wOG7hF4BICyajI5O0V7FOa+Zo1XmIfAsiwxrioQmVi0=@vger.kernel.org X-Gm-Message-State: AOJu0YwkfkmmZBn1F2jwlnR0xP1wvUuPFxUDjt6sjwsHx+qPwFfR/QDl /hAQjvkDp3aazkkJfpuFwMx7Zonf6n4pkTKRlhJ2r5Nfmi5omY2mR7FzkBV5QDH+exXdXZPGbBn UBioINj9eeobg/njkOz5qlIb3TAlqKZE3Dj6IgvbC2+86Ir3Rnoqx27ePqNOt3PyYNw== X-Gm-Gg: ASbGncs9vCjPoxCxRCG75spzWWPcrRZ2spOl5IGATbcdrVpVGD+IWlaZj+Qnufzd6id Hk1a1g3RnrvEYgZQMITmrfFemS2o630ZUk28eFRjfK3I1avjbvzQQZj1P2L4Kf8Zo+Fios4Rulw kPynrHgUfZZ9D+cqeFcx6unqXPrwHeC17BJye0MQG+J8aKZwh+lY2BmzdYM2Ew1fNXlp/yUJlgX wonjyHZES56nJhpsZshKVrCwpQNeUSghmWM5jnFkNs3fTbFMvWqR0+dlAM4CCeeRSii62BwF93s P3HRRvsTiTPzMLBs6Rrbm/uKTw+Ocj2DN72yI9T4npZGZNrJANtd3E/3W/wDLV4Kh7sm+Qa9EGs fFmrb X-Received: by 2002:a05:600c:3ba2:b0:441:b00d:e9d1 with SMTP id 5b1f17b1804b1-4538ee15a09mr27052105e9.2.1751010703341; Fri, 27 Jun 2025 00:51:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG84NMS43tLU4/bepm0RU/vh1jVbKdij5j7ryp5JJCNaNfJj8+Z/Tw54L4wr9lRRNPbvhEdWQ== X-Received: by 2002:a05:600c:3ba2:b0:441:b00d:e9d1 with SMTP id 5b1f17b1804b1-4538ee15a09mr27051735e9.2.1751010702905; Fri, 27 Jun 2025 00:51:42 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538233c5fasm74208765e9.8.2025.06.27.00.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jun 2025 00:51:42 -0700 (PDT) From: Javier Martinez Canillas To: Luca Weiss , Hans de Goede , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss Subject: Re: [PATCH v2 3/5] drm/sysfb: simpledrm: Add support for interconnect paths In-Reply-To: <20250623-simple-drm-fb-icc-v2-3-f69b86cd3d7d@fairphone.com> References: <20250623-simple-drm-fb-icc-v2-0-f69b86cd3d7d@fairphone.com> <20250623-simple-drm-fb-icc-v2-3-f69b86cd3d7d@fairphone.com> Date: Fri, 27 Jun 2025 09:51:41 +0200 Message-ID: <87qzz5d3le.fsf@minerva.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Luca Weiss writes: > Some devices might require keeping an interconnect path alive so that > the framebuffer continues working. Add support for that by setting the > bandwidth requirements appropriately for all provided interconnect > paths. > > Reviewed-by: Thomas Zimmermann > Signed-off-by: Luca Weiss > --- > drivers/gpu/drm/sysfb/simpledrm.c | 83 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 83 insertions(+) > > diff --git a/drivers/gpu/drm/sysfb/simpledrm.c b/drivers/gpu/drm/sysfb/simpledrm.c > index 349219330314e3421a6bb26ad5cf39a679a5cb7a..47d213e20cab1dd1e19528674a95edea00f4bb30 100644 > --- a/drivers/gpu/drm/sysfb/simpledrm.c > +++ b/drivers/gpu/drm/sysfb/simpledrm.c > @@ -2,6 +2,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -225,6 +226,10 @@ struct simpledrm_device { > struct device **pwr_dom_devs; > struct device_link **pwr_dom_links; > #endif Can you add a /* interconnects */ comment here? Similarly how there is one for clocks, regulators, power domains, etc. > +#if defined CONFIG_OF && defined CONFIG_INTERCONNECT > + unsigned int icc_count; > + struct icc_path **icc_paths; > +#endif > ... > +static int simpledrm_device_attach_icc(struct simpledrm_device *sdev) > +{ > + struct device *dev = sdev->sysfb.dev.dev; > + int ret, count, i; > + > + count = of_count_phandle_with_args(dev->of_node, "interconnects", > + "#interconnect-cells"); > + if (count < 0) > + return 0; > + > + /* An interconnect path consists of two elements */ > + if (count % 2) { > + drm_err(&sdev->sysfb.dev, > + "invalid interconnects value\n"); > + return -EINVAL; > + } > + sdev->icc_count = count / 2; > + > + sdev->icc_paths = devm_kcalloc(dev, sdev->icc_count, > + sizeof(*sdev->icc_paths), > + GFP_KERNEL); > + if (!sdev->icc_paths) > + return -ENOMEM; > + > + for (i = 0; i < sdev->icc_count; i++) { > + sdev->icc_paths[i] = of_icc_get_by_index(dev, i); > + if (IS_ERR_OR_NULL(sdev->icc_paths[i])) { > + ret = PTR_ERR(sdev->icc_paths[i]); > + if (ret == -EPROBE_DEFER) > + goto err; > + drm_err(&sdev->sysfb.dev, "failed to get interconnect path %u: %d\n", > + i, ret); You could use dev_err_probe() instead that already handles the -EPROBE_DEFER case and also will get this message in the /sys/kernel/debug/devices_deferred debugfs entry, as the reason why the probe deferral happened. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat