Re: [PATCH] ALSA: hda_acpi: eliminate defined but not used warnings

[Takashi Iwai <tiwai@suse.de>]

On Thu, 22 May 2025 22:30:20 +0200,
Randy Dunlap wrote:
> 
> When CONFIG_PM_SLEEP is not set, the hda_acpi_suspend() and
> hda_acpi_resume() functions are not used and cause build warnings:
> 
> sound/pci/hda/hda_acpi.c:282:12: warning: 'hda_acpi_resume' defined but not used [-Wunused-function]
>   282 | static int hda_acpi_resume(struct device *dev)
> sound/pci/hda/hda_acpi.c:269:12: warning: 'hda_acpi_suspend' defined but not used [-Wunused-function]
>   269 | static int hda_acpi_suspend(struct device *dev)
> 
> Enclose these functions inside an ifdef CONFIG_PM_SLEEP block to
> prevent the warnings.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Daniel Dadap <ddadap@nvidia.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: linux-sound@vger.kernel.org

Err, it just an incorrect use of SET_SYSTEM_SLEEP_PM_OPS() instead of
SYSTEM_SLEEP_OPS().  It seems that v5 patch went back to a wrong
macro, likely mistakenly.

A fix patch will follow.


thanks,

Takashi