From: Jonathan Corbet <corbet@lwn.net>
To: Vincenzo Mezzela <vincenzo.mezzela@gmail.com>,
andersson@kernel.org, mathieu.poirier@linaro.org
Cc: linux-remoteproc@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
Vincenzo Mezzela <vincenzo.mezzela@gmail.com>
Subject: Re: [PATCH] docs: staging: fix typo in docs
Date: Thu, 08 Feb 2024 15:42:41 -0700 [thread overview]
Message-ID: <87r0hmfuhq.fsf@meer.lwn.net> (raw)
In-Reply-To: <20240208162748.111120-1-vincenzo.mezzela@gmail.com>
Vincenzo Mezzela <vincenzo.mezzela@gmail.com> writes:
So your fix is fine, but I need to point out a couple of things with the
changelog.
> This patch resolves a spelling error in the documentation found
> with codespell.
If you look at Documentation/process/submitting-patches.rst, you'll see
that changelog text should be phrased in the imperative mode; no "this
patch". I tend not to be too fussy about that, but some maintainers
will reject a patch out of hand for that, so it's a good thing to learn
to avoid.
> It is submitted as part of my application to the "Linux Kernel Bug
> Fixing Spring Unpaid 2024" mentorship program of the Linux Kernel
> Foundation.
This is interesting (I'd never heard of the Linux Kernel Foundation),
but it's not really relevant for the kernel development history. If you
want to put this kind of information in a submission, put it after the
"---" line so that it doesn't end up being committed with the patch.
> Signed-off-by: Vincenzo Mezzela <vincenzo.mezzela@gmail.com>
I have gone ahead and fixed up these things and applied your two
patches, thanks.
jon
next prev parent reply other threads:[~2024-02-08 22:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 16:27 Vincenzo Mezzela
2024-02-08 22:42 ` Jonathan Corbet [this message]
2024-02-09 8:47 ` vincenzo mezzela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0hmfuhq.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=andersson@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=skhan@linuxfoundation.org \
--cc=vincenzo.mezzela@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®