From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0378DC3DA6F for ; Thu, 24 Aug 2023 17:44:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242593AbjHXRoU (ORCPT ); Thu, 24 Aug 2023 13:44:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242649AbjHXRoH (ORCPT ); Thu, 24 Aug 2023 13:44:07 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32BF01BD9 for ; Thu, 24 Aug 2023 10:44:06 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EA71F21E3F; Thu, 24 Aug 2023 17:44:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1692899044; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eoa2qiu7Pb8Mej/ksgnMC+QAXJFSGjCz8Q+iS5utF28=; b=G5UpjZs/mQh3VwjtrfzG3fFvmrjFdFaz57SAYLChH+uiSdJ8sc3e66vocEU3o1nZqEDa7Q rQfX2i4YpQ1Yo0NdXG5M/5/nNCAOVclqFT8tLraSIMBmMAYFXysz+XXfrhXY/v2nNrRdYM KrPiU/Fo2PGcuFM/gyOyVDxekELbU5w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1692899044; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eoa2qiu7Pb8Mej/ksgnMC+QAXJFSGjCz8Q+iS5utF28=; b=NAbZXD0LS7flBlWFEKj+UWqc4XTyhHSmbwMYpDGXLdZ3FFFA/Bk9YbD8augwNBhNixraxe TU0vbGFLtjjq7PDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B1CBE1336F; Thu, 24 Aug 2023 17:44:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KWJmKuSW52Q/fwAAMHmgww (envelope-from ); Thu, 24 Aug 2023 17:44:04 +0000 Date: Thu, 24 Aug 2023 19:44:04 +0200 Message-ID: <87r0ns8hej.wl-tiwai@suse.de> From: Takashi Iwai To: SungHwan Jung Cc: fabian@ritter-vogt.de, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, perex@perex.cz, tiwai@suse.com Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for mute LEDs on HP ENVY x360 15-eu0xxx In-Reply-To: <20230824173718.7992-1-onenowy@gmail.com> References: <4504056.LvFx2qVVIh@fabians-envy> <20230824173718.7992-1-onenowy@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Aug 2023 19:37:18 +0200, SungHwan Jung wrote: > > On Fri, Aug 25, 2023 at 12:57 AM Fabian Vogt wrote: > > I see that SungHwan Jung (CC'd) recently submitted the same fixup for > > a rather similar but different model as > > "ALSA: hda/realtek: Add quirk for HP Victus 16-d1xxx to enable mute LED" > > Does your HP Victus also need the ALC245_FIXUP_HP_GPIO_LED? Then we could > > combine the quirks. > > These victus laptops don't need ALC245_FIXUP_HP_GPIO_LED, but we can make > alc245_fixup_hp_x360_mute_led and alc245_fixup_hp_mute_led_coefbit into > one function. ShungHwan's patch was already merged, so we can just reuse the function in a new quirk; ALC245_FIXUP_HP_X360_MUTE_LED will be calling alc245_fixup_hp_mute_led_coefbit and chained to ALC245_FIXUP_HP_GPIO_LED. Fabian, could you resubmit such a patch? thanks, Takashi