From: "Björn Töpel" <bjorn@kernel.org>
To: Alexandre Ghiti <alex@ghiti.fr>,
Alexandre Ghiti <alexghiti@rivosinc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alan Kao <alankao@andestech.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Bo YU <tsu.yubo@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH -fixes] riscv: uaccess: Return the number of bytes effectively copied
Date: Fri, 11 Aug 2023 14:33:53 +0200 [thread overview]
Message-ID: <87r0o9ahce.fsf@all.your.base.are.belong.to.us> (raw)
In-Reply-To: <dff5c443-bebf-9bd9-af1c-85ebfb7c2aec@ghiti.fr>
Alexandre Ghiti <alex@ghiti.fr> writes:
> On 11/08/2023 13:03, Alexandre Ghiti wrote:
>> It was reported that the riscv kernel hangs while executing the test
>> in [1].
>>
>> Indeed, the test hangs when trying to write a buffer to a file. The
>> problem is that the riscv implementation of raw_copy_from_user() does not
>> return the number of bytes written when an exception happens and is fixed
>> up.
>
>
> I'll respin another version as the changelog and the title are
> incorrect: the uaccess routines should not return the number of bytes
> copied but actually the number of bytes not copied (this is what this
> patch implements).
>
> I'll wait for feedbacks before doing so!
Yikes! Nice catch.
Functions like fault_in_readable() will fail horribly w/o this. I wonder
why we haven't seen this problem more?
Feel free to add my RB to your next spin!
Reviewed-by: Björn Töpel <bjorn@rivosinc.com>
next prev parent reply other threads:[~2023-08-11 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 11:03 Alexandre Ghiti
2023-08-11 11:39 ` Alexandre Ghiti
2023-08-11 11:54 ` Conor Dooley
2023-08-11 12:33 ` Björn Töpel [this message]
2023-08-11 14:35 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0o9ahce.fsf@all.your.base.are.belong.to.us \
--to=bjorn@kernel.org \
--cc=alankao@andestech.com \
--cc=alex@ghiti.fr \
--cc=alexghiti@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=aurelien@aurel32.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=tsu.yubo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®