From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A8FBEB64DC for ; Thu, 15 Jun 2023 06:44:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243547AbjFOGoC (ORCPT ); Thu, 15 Jun 2023 02:44:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244127AbjFOGnT (ORCPT ); Thu, 15 Jun 2023 02:43:19 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB44926A8; Wed, 14 Jun 2023 23:41:54 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 59FCC1F381; Thu, 15 Jun 2023 06:41:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686811313; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ft/zj4ilzEumTWLpEQ07nLe+sIIdIKTeXHm4HA2N188=; b=17hpmG/Maa7k+KgeOcBx2Qx6wOPTd9n9rIMnpJNKnxLDW00TA6tw8GbwgCDwMxvj79LO/T tHobk0dCZEbtSR1g7jLCIFiJFSWvmW30QMYq38dqqB/qmz0Yo7adaLr/V/pAWNivyKVp9M 75q7VDLJ2KLfDZ1WZu4LJR7Lm7ntpbo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686811313; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ft/zj4ilzEumTWLpEQ07nLe+sIIdIKTeXHm4HA2N188=; b=sZitHZ+ZzbnztOhMC8NH8z4v1JHREWOq2w+ssNFnk6QfFeJFf8rdYCt0+VgX31Y9Jph5IF PvUh+e1jO3DriiCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1B68B13467; Thu, 15 Jun 2023 06:41:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /rG8BbGyimS9eAAAMHmgww (envelope-from ); Thu, 15 Jun 2023 06:41:53 +0000 Date: Thu, 15 Jun 2023 08:41:52 +0200 Message-ID: <87r0qd8bwv.wl-tiwai@suse.de> From: Takashi Iwai To: Su Hui Cc: Jaroslav Kysela , Takashi Iwai , Arnd Bergmann , maciej.szmigiero@oracle.com, yangyingliang@huawei.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: ac97: Fix possible NULL dereference in snd_ac97_mixer In-Reply-To: <20230615021732.1972194-1-suhui@nfschina.com> References: <20230615021732.1972194-1-suhui@nfschina.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Jun 2023 04:17:32 +0200, Su Hui wrote: > > smatch error: > sound/pci/ac97/ac97_codec.c:2354 snd_ac97_mixer() error: > we previously assumed 'rac97' could be null (see line 2072) > > remove redundant assignment, return error if rac97 is NULL. > > Fixes: da3cec35dd3c ("ALSA: Kill snd_assert() in sound/pci/*") > Signed-off-by: Su Hui Thanks, applied. Takashi