From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83613C433F5 for ; Mon, 30 May 2022 06:22:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232756AbiE3GW4 (ORCPT ); Mon, 30 May 2022 02:22:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232574AbiE3GWw (ORCPT ); Mon, 30 May 2022 02:22:52 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47CAAB48F for ; Sun, 29 May 2022 23:22:51 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BD09C21B1B; Mon, 30 May 2022 06:22:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1653891769; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gMK+OeBa4dLe/9qKEl+zy+cCJeaoiWjWn1lzVIiR6ps=; b=yKXlivbbyZa2dYb4CMFVs6O5uTT9Wt/JOFXmnbssU4ij54SnpVmd3xqhk4IVcinW1hswce RmLSPM/jw2sUTQmHUeBEhf/3NJHWhslxD2F9TTaypjySyVxF27qavuGmFy+q0kQ37RnSPl mu+7Jpc7JNMheZLfRLV7qL6ryLoQFRA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1653891769; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gMK+OeBa4dLe/9qKEl+zy+cCJeaoiWjWn1lzVIiR6ps=; b=qsvefCWj8PNpvbtp/UChtAOvP4KNfagzG2CeAIqlowhPLmz32EwNzYIcTefqk+Kn+lAa2D PYiP2fAX0OmwEmCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8B94F13AFD; Mon, 30 May 2022 06:22:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ZW9OIblilGKzWAAAMHmgww (envelope-from ); Mon, 30 May 2022 06:22:49 +0000 Date: Mon, 30 May 2022 08:22:49 +0200 Message-ID: <87r14by1xi.wl-tiwai@suse.de> From: Takashi Iwai To: Marios Levogiannis Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek - Fix microphone noise on ASUS TUF B550M-PLUS In-Reply-To: <20220529223524.9057-1-marios.levogiannis@gmail.com> References: <20220529223524.9057-1-marios.levogiannis@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 May 2022 00:35:24 +0200, Marios Levogiannis wrote: > > Set microphone pins 0x18 (rear) and 0x19 (front) to VREF_50 to fix the > microphone noise on ASUS TUF B550M-PLUS which uses the ALCS1200A codec. > The initial value was VREF_80. > > The same issue is also present on Windows using both the default Windows > driver and all tested Realtek drivers before version 6.0.9049.1. Comparing > Realtek driver 6.0.9049.1 (the first one without the microphone noise) to > Realtek driver 6.0.9047.1 (the last one with the microphone noise) > revealed that the fix is the result of setting pins 0x18 and 0x19 to > VREF_50. > > This fix may also work for other boards that have been reported to have > the same microphone issue and use the ALC1150 and ALCS1200A codecs, since > these codecs are similar and the fix in the Realtek driver on Windows is > common for both. However, it is currently enabled only for ASUS TUF > B550M-PLUS as this is the only board that could be tested. Could you resubmit with your Signed-off-by tag? It's mandatory. thanks, Takashi