From: Jonathan Corbet <corbet@lwn.net>
To: YI <afctgo@gmail.com>, trivial@kernel.org
Cc: YI <afctgo@gmail.com>, Andrew Morton <akpm@linux-foundation.org>,
Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>,
Kalesh Singh <kaleshsingh@google.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Colin Cross <ccross@google.com>, Mike Rapoport <rppt@kernel.org>,
Peter Xu <peterx@redhat.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] docs: proc.rst: fix wrong time unit
Date: Wed, 09 Mar 2022 16:26:16 -0700 [thread overview]
Message-ID: <87r17a7lnr.fsf@meer.lwn.net> (raw)
In-Reply-To: <20220302161122.3984304-1-uuuuuu@protonmail.com>
YI <afctgo@gmail.com> writes:
> From: YI <afctgo@gmail.com>
>
> Dear Trivial Patch Monkey,
The trivial patch monkey has gone into retirement, I'm as close as
you're going to get.
> This commit fixes a small documentaion problem reported in
> https://bugzilla.kernel.org/show_bug.cgi?id=194593.
>
> Some fields in the file /proc/$pid/stat represent time.
> Their units are clock_t, not jiffies as stated in the documentation.
> This commit fixes https://bugzilla.kernel.org/show_bug.cgi?id=194593.
We certainly don't need to give the bugzilla URL twice; I'm not
convinced it's needed even once. The changelog should just say what the
patch does, please.
Also, "clock_t" isn't really a unit type; what are the actual units of
the field?
> Reported-by: hujunjie
This isn't a valid reported-by line
> Signed-off-by: YI <afctgo@gmail.com>
...and the signoff need to have your full name, please.
Thanks,
jon
prev parent reply other threads:[~2022-03-09 23:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 16:11 YI
2022-03-09 23:26 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r17a7lnr.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=afctgo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ccross@google.com \
--cc=kaleshsingh@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@christoph.anton.mitterer.name \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=trivial@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®