From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C8B5C388F7 for ; Sat, 7 Nov 2020 18:12:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 027EE20885 for ; Sat, 7 Nov 2020 18:12:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728563AbgKGSMs (ORCPT ); Sat, 7 Nov 2020 13:12:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726614AbgKGSMs (ORCPT ); Sat, 7 Nov 2020 13:12:48 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 600A2C0613CF for ; Sat, 7 Nov 2020 10:12:48 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: aratiu) with ESMTPSA id 5B9641F453A0 From: Adrian Ratiu To: Russell King - ARM Linux admin Cc: linux-arm-kernel@lists.infradead.org, Nathan Chancellor , Nick Desaulniers , Arnd Bergmann , clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization In-Reply-To: <20201107102203.GV1551@shell.armlinux.org.uk> References: <20201106051436.2384842-1-adrian.ratiu@collabora.com> <20201106051436.2384842-3-adrian.ratiu@collabora.com> <20201107102203.GV1551@shell.armlinux.org.uk> Date: Sat, 07 Nov 2020 20:12:39 +0200 Message-ID: <87r1p5ujc8.fsf@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 07 Nov 2020, Russell King - ARM Linux admin wrote: > On Fri, Nov 06, 2020 at 07:14:36AM +0200, Adrian Ratiu wrote: >> diff --git a/arch/arm/lib/xor-neon.c b/arch/arm/lib/xor-neon.c >> index e1e76186ec23..84c91c48dfa2 100644 --- >> a/arch/arm/lib/xor-neon.c +++ b/arch/arm/lib/xor-neon.c @@ >> -18,6 +18,10 @@ MODULE_LICENSE("GPL"); >> * Pull in the reference implementations while instructing GCC >> (through * -ftree-vectorize) to attempt to exploit implicit >> parallelism and emit * NEON instructions. >> + > > Please tidy this up before submission; we normally continue the > "*" for blank lines in comment blocks. Thanks. Indeed, thank you. I will fix it if I don't replace this patch entirely with something similar to what Nick suggested. Perhaps adding a checkpatch test for this is a good idea? Adrian > >> + * On Clang the loop vectorizer is enabled by default, but due to a bug >> + * (https://bugs.llvm.org/show_bug.cgi?id=40976) vectorization is broke >> + * so xor-neon is disabled in favor of the default reg implementations. >> */ >> #ifdef CONFIG_CC_IS_GCC >> #pragma GCC optimize "tree-vectorize" >> -- >> 2.29.0 >> >> > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!