From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753123AbdK2DBZ (ORCPT ); Tue, 28 Nov 2017 22:01:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:52782 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752248AbdK2DBX (ORCPT ); Tue, 28 Nov 2017 22:01:23 -0500 From: NeilBrown To: Greg Kroah-Hartman Date: Wed, 29 Nov 2017 14:01:12 +1100 Cc: Oleg Drokin , Andreas Dilger , James Simmons , linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org Subject: Re: [PATCH 08/10] staging: lustre: lov: use list_for_each_entry in lov_obd.c In-Reply-To: <20171124154341.GA16654@kroah.com> References: <150933945578.22133.8029060522107378499.stgit@noble> <150933956729.22133.13130557672702877610.stgit@noble> <20171124154341.GA16654@kroah.com> Message-ID: <87r2shwzyf.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: [PATCH] staging: lustre: lov: use list_for_each_entry in lov_obd.c Using the *_entry macro simplifies the code slightly. Signed-off-by: NeilBrown =2D-- Resubmitted with non-empty changelog text. Thanks, NeilBrown drivers/staging/lustre/lustre/lov/lov_obd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c b/drivers/staging/= lustre/lustre/lov/lov_obd.c index 7ce01026a409..ec70c12e5b40 100644 =2D-- a/drivers/staging/lustre/lustre/lov/lov_obd.c +++ b/drivers/staging/lustre/lustre/lov/lov_obd.c @@ -828,11 +828,9 @@ int lov_setup(struct obd_device *obd, struct lustre_cf= g *lcfg) static int lov_cleanup(struct obd_device *obd) { struct lov_obd *lov =3D &obd->u.lov; =2D struct list_head *pos, *tmp; =2D struct pool_desc *pool; + struct pool_desc *pool, *tmp; =20 =2D list_for_each_safe(pos, tmp, &lov->lov_pool_list) { =2D pool =3D list_entry(pos, struct pool_desc, pool_list); + list_for_each_entry_safe(pool, tmp, &lov->lov_pool_list, pool_list) { /* free pool structs */ CDEBUG(D_INFO, "delete pool %p\n", pool); /* In the function below, .hs_keycmp resolves to =2D-=20 2.14.0.rc0.dirty --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAloeIvgACgkQOeye3VZi gbmR+Q/+OWozFykp8lqT9UV+qCf8gwDlRXsGfMa2NQ3zMupMfba5Ra9VYED8s5o+ n4eksJO7R98UnO1wlAkH27iLzX+OOTTgUnDotnzUmilBuCWBUcjMB82Q33jM8jEw 6R2kljBFv9dyvud3jDyrZZWEHudaUKu+DyK67UEdekrPThjaJYwZKxqsCroM49XP a4yzoW2bRTar3u3k89P1hSKnVGsVjowf0+ND80FKU04GY0skx1jQwx1mJPbraXk3 /0tawIaTBEuIPvI+FTGhkLBxyiHEWqZllx0HxAppbALCNga3mGAXdVP61VDqefhJ G/ZBh0J1itokR12oVw6mhjHLqHWcsErDfuidnbYl9mERFZlKJOOY1lQFiktepPpE vYzidvDLumRlLcXEMGlnbT5tUguM2l3HdNSnqAty62yewnai/Rb4aidnF/PLSvn+ a6k9WIgCm+Kj1qby6GVfSRCSJgQ/BoDaWeIp9EiQxWEldR30P56xJlstaKzr1f1d jnZ2zYBrsTyWHY+Mp+c27SjFB2wz+pg8sEvVxxHefKIsw4UWEy+r4WqE3YrMIE9N HJK13yjLVEWAh8NwmcbhwH9w5Wi6u0jXOusl42nnQuBjq+iW1t+b9tJVxmHAGs1Z a1oTVRsgkS6gWsffQaclPEqk3JtVROujpGxteK3Wf0PBfkV/6fU= =Qgwj -----END PGP SIGNATURE----- --=-=-=--