From: Michael Ellerman <mpe@ellerman.id.au>
To: Anton Blanchard <anton@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Nicholas Piggin <npiggin@gmail.com>,
ravi.bangoria@linux.vnet.ibm.com, acme@redhat.com,
peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: perf TUI fails with "failed to process type: 64"
Date: Mon, 10 Oct 2016 21:39:25 +1100 [thread overview]
Message-ID: <87r37o5vz6.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20161010211812.13eb89d5@kryten>
Anton Blanchard <anton@samba.org> writes:
>> > 14c00-14c00 g exc_virt_0x4c00_system_call
>> ^
>> What's this? The address? If so it's wrong?
>
> Offset into the binary I think, there's one 64kB page of ELF gunk at
> the start.
Ah OK makes sense.
>> So more digging required.
>
> Thanks for checking, it's starting to sound like a perf bug.
Yeah possibly. I'll build an updated perf tomorrow and see if I can
reproduce.
As an aside, it looks like it would be easy to set the size with the new
macro. Does the patch below help at all?
The other thing Nick mentioned is we could set the type of those symbols
to function, though that's not entirely correct. But it might help perf
and probably wouldn't break anything else (that I can think of right now
anyway).
cheers
diff --git a/arch/powerpc/include/asm/head-64.h b/arch/powerpc/include/asm/head-64.h
index ab90c2fa1ea6..0e250d4eff44 100644
--- a/arch/powerpc/include/asm/head-64.h
+++ b/arch/powerpc/include/asm/head-64.h
@@ -122,6 +122,7 @@ name:
.error "Fixed entry overflow"; \
.abort; \
.endif; \
+ .size name, (. - name); \
. = ((end) - sname##_start); \
next prev parent reply other threads:[~2016-10-10 10:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 1:12 Anton Blanchard
2016-10-10 5:02 ` Michael Ellerman
2016-10-10 5:59 ` Nicholas Piggin
2016-10-10 10:18 ` Anton Blanchard
2016-10-10 10:39 ` Michael Ellerman [this message]
2016-11-21 6:28 ` Anton Blanchard
2016-11-22 8:40 ` [PATCH] perf TUI: Don't throw error for zero length symbols Ravi Bangoria
2016-11-22 8:49 ` Ravi Bangoria
2016-11-22 8:56 ` Ravi Bangoria
2016-12-16 10:38 ` Ravi Bangoria
2016-12-16 20:27 ` Anton Blanchard
2016-12-19 18:15 ` Arnaldo Carvalho de Melo
2016-12-20 19:30 ` [tip:perf/urgent] perf annotate: " tip-bot for Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r37o5vz6.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®