From: Eric Anholt <eric@anholt.net>
To: "Noralf Trønnes" <noralf@tronnes.org>,
wsa@the-dreams.de, swarren@wwwdotorg.org
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
"Noralf Trønnes" <noralf@tronnes.org>
Subject: Re: [PATCH v3 7/7] i2c: bcm2835: Add support for dynamic clock
Date: Wed, 28 Sep 2016 14:24:36 -0700 [thread overview]
Message-ID: <87r383g1kb.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1475085056-5205-8-git-send-email-noralf@tronnes.org>
[-- Attachment #1: Type: text/plain, Size: 639 bytes --]
Noralf Trønnes <noralf@tronnes.org> writes:
> Support a dynamic clock by reading the frequency and setting the
> divisor in the transfer function instead of during probe.
Is this fixing some particular case you could note in the commit
message? As is, it makes me think that we should be using a notifier
for when the parent clock (that's the one I assume you're talking about
being dynamic) changes. But maybe you're working around a variable VPU
clock being set by the firmware, because we don't have a notifier for
it?
I'm a bit worried because I think this is going to be pretty expensive
to be doing per transfer.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
next prev parent reply other threads:[~2016-09-28 21:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 17:50 [PATCH v3 0/7] i2c: bcm2835: Bring in changes from downstream Noralf Trønnes
2016-09-28 17:50 ` [PATCH v3 1/7] i2c: bcm2835: Fix hang for writing messages larger than 16 bytes Noralf Trønnes
2016-09-28 17:50 ` [PATCH v3 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts Noralf Trønnes
2016-09-28 22:00 ` Eric Anholt
2016-09-28 22:22 ` Noralf Trønnes
2016-09-29 5:37 ` Stefan Wahren
2016-10-02 14:19 ` Noralf Trønnes
2016-10-03 18:58 ` Eric Anholt
2016-10-03 19:42 ` Eric Anholt
2016-10-04 19:24 ` Noralf Trønnes
2016-09-28 17:50 ` [PATCH v3 3/7] i2c: bcm2835: Use dev_dbg logging on transfer errors Noralf Trønnes
2016-09-29 11:05 ` Martin Sperl
2016-09-28 17:50 ` [PATCH v3 4/7] i2c: bcm2835: Can't support I2C_M_IGNORE_NAK Noralf Trønnes
2016-09-28 17:50 ` [PATCH v3 5/7] i2c: bcm2835: Add support for Repeated Start Condition Noralf Trønnes
2016-09-28 17:50 ` [PATCH v3 6/7] i2c: bcm2835: Support i2c-dev ioctl I2C_TIMEOUT Noralf Trønnes
2016-09-28 17:50 ` [PATCH v3 7/7] i2c: bcm2835: Add support for dynamic clock Noralf Trønnes
2016-09-28 21:24 ` Eric Anholt [this message]
2016-09-28 22:10 ` Noralf Trønnes
2016-09-29 8:02 ` Martin Sperl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r383g1kb.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=noralf@tronnes.org \
--cc=swarren@wwwdotorg.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®