From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: changbin.du@intel.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, "Du\,
Changbin" <changbin.du@intel.com>
Subject: Re: [PATCH] usb: dwc3: rename __dwc3_cleanup_done_trbs to __dwc3_cleanup_one_trb
Date: Wed, 30 Mar 2016 13:57:13 +0300 [thread overview]
Message-ID: <87r3esp71y.fsf@intel.com> (raw)
In-Reply-To: <1459332836-11579-1-git-send-email-changbin.du@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]
Hi,
changbin.du@intel.com writes:
> [ text/plain ]
> From: "Du, Changbin" <changbin.du@intel.com>
>
> Actually, the function only clean one trb. So rename the function.
>
> Signed-off-by: Du, Changbin <changbin.du@intel.com>
okay :-)
> ---
> drivers/usb/dwc3/gadget.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 3ac170f..f84be3d 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -1873,7 +1873,7 @@ static void dwc3_gadget_free_endpoints(struct dwc3 *dwc)
>
> /* -------------------------------------------------------------------------- */
>
> -static int __dwc3_cleanup_done_trbs(struct dwc3 *dwc, struct dwc3_ep *dep,
> +static int __dwc3_cleanup_one_trb(struct dwc3 *dwc, struct dwc3_ep *dep,
I would rather just remove that 's' from the end so the function's name
stays as __dwc3_cleanup_done_trb() ;-)
Care to do that ?
thanks
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-03-30 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 10:13 changbin.du
2016-03-30 10:57 ` Felipe Balbi [this message]
2016-03-30 11:04 ` Du, Changbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3esp71y.fsf@intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=changbin.du@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®