From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755385AbbLKRdb (ORCPT ); Fri, 11 Dec 2015 12:33:31 -0500 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:58136 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244AbbLKRda (ORCPT ); Fri, 11 Dec 2015 12:33:30 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Fri, 11 Dec 2015 18:33:26 +0100 X-ME-IP: 92.156.1.80 From: Robert Jarzmik To: Philipp Zabel Cc: Lee Jones , Thierry Reding , linux-pwm@vger.kernel.org, kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] backlight: pwm_bl: Fix broken PWM backlight for non-dt platforms References: <1449738546-10279-1-git-send-email-p.zabel@pengutronix.de> X-URL: http://belgarath.falguerolles.org/ Date: Fri, 11 Dec 2015 18:33:22 +0100 In-Reply-To: <1449738546-10279-1-git-send-email-p.zabel@pengutronix.de> (Philipp Zabel's message of "Thu, 10 Dec 2015 10:09:06 +0100") Message-ID: <87r3isj3fh.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Philipp Zabel writes: > Commit ee65ad0e2a9e ("backlight: pwm_bl: Avoid backlight flicker when > probed from DT") tries to dereference the device of_node pointer > unconditionally, causing a NULL pointer dereference on non-dt platforms. > Fix it by replacing the phandle variable with a node variable and > by checking that for NULL before dereferencing it. > > Reported-by: Robert Jarzmik > Signed-off-by: Philipp Zabel And indeed it does the trick. Tested-by: Robert Jarzmik -- Robert