From: Robert Jarzmik <robert.jarzmik@free.fr>
To: David Miller <davem@davemloft.net>
Cc: samuel@sortiz.org, petr.cvek@tul.cz, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management
Date: Tue, 22 Sep 2015 21:27:51 +0200 [thread overview]
Message-ID: <87r3lqp83s.fsf@belgarion.home> (raw)
In-Reply-To: <20150921.161235.605756522215336833.davem@davemloft.net> (David Miller's message of "Mon, 21 Sep 2015 16:12:35 -0700 (PDT)")
David Miller <davem@davemloft.net> writes:
> From: Robert Jarzmik <robert.jarzmik@free.fr>
> Date: Fri, 18 Sep 2015 18:36:56 +0200
>
>> Which brings me to wonder which is the more correct :
>> (a) replace to reproduce the same calculation
>> Previously mtt was compared to a difference of 76ns steps (as 307ns / 4 =
>> 76ns):
>> while ((sched_clock() - si->last_clk) * 76 < mtt)
>>
>> (b) change the calculation assuming mtt is in microseconds :
>> while ((sched_clock() - si->last_clk) * 1000 < mtt)
>>
>> I have no IRDA protocol knowledge so unless someone points me to the correct
>> calculation I'll try my luck with (b).
>
> "a" would be "safer" and less likely to break anything, although as
> you say "b" might be more correct.
Indeed.
Well, let me try (b) then. I'll add in the commit message the timings change,
and if anybody complains a regression pops out, I'll provide a patch to fallback
to (a).
Cheers.
--
Robert
prev parent reply other threads:[~2015-09-22 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-12 11:45 Robert Jarzmik
2015-09-12 11:45 ` [PATCH v2 2/3] net: irda: pxaficp_ir: convert to readl and writel Robert Jarzmik
2015-09-13 1:34 ` Petr Cvek
2015-09-12 11:45 ` [PATCH v2 3/3] net: irda: pxaficp_ir: dmaengine conversion Robert Jarzmik
2015-09-15 23:40 ` [PATCH v2 1/3] net: irda: pxaficp_ir: use sched_clock() for time management David Miller
2015-09-16 9:34 ` Robert Jarzmik
2015-09-17 21:51 ` David Miller
2015-09-18 16:36 ` Robert Jarzmik
2015-09-21 23:12 ` David Miller
2015-09-22 19:27 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3lqp83s.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petr.cvek@tul.cz \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®