From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932693AbbELMGg (ORCPT ); Tue, 12 May 2015 08:06:36 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:35296 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932665AbbELMGa (ORCPT ); Tue, 12 May 2015 08:06:30 -0400 From: Rasmus Villemoes To: Darren Hart Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: wmi: Remove private %pUL implementation Organization: D03 References: <1424787330-26770-1-git-send-email-linux@rasmusvillemoes.dk> <20150306175232.GC19001@vmdeb7> X-Hashcash: 1:20:150512:platform-driver-x86@vger.kernel.org::v+gBzLacZYrYORmN:000000000000000000000000000AdH X-Hashcash: 1:20:150512:dvhart@infradead.org::gXIlMQlcI+CZNwgs:0000000000000000000000000000000000000000013kU X-Hashcash: 1:20:150512:linux-kernel@vger.kernel.org::K3Cj3Rs1y9vKXG8v:0000000000000000000000000000000004hA3 Date: Tue, 12 May 2015 14:06:27 +0200 In-Reply-To: <20150306175232.GC19001@vmdeb7> (Darren Hart's message of "Fri, 6 Mar 2015 09:52:32 -0800") Message-ID: <87r3qm6lvg.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 06 2015, Darren Hart wrote: > On Tue, Feb 24, 2015 at 03:15:30PM +0100, Rasmus Villemoes wrote: >> The work performed by wmi_gtoa is equivalent to simply sprintf(out, >> "%pUL", in), so one could replace its body by this. However, most >> users feed the result directly as a %s argument to some other function >> which also understands the %p extensions (they all ultimately use >> vsnprintf), so we can eliminate some stack buffers and quite a bit of >> code by just using %pUL directly. >> >> In wmi_dev_uevent I'm not sure whether there's room for a >> nul-terminator in env->buf, so I've just replaced wmi_gtoa with the >> equivalent sprintf call. >> >> Signed-off-by: Rasmus Villemoes > > Nice cleanup, thanks Rasmus. Queued for 4.1. Hi Darren This seems to have fallen through the cracks - I don't see it in 4.1-rc3. Rasmus