From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: Tyler Hall <tylerwhall@gmail.com>,
"linux-gpio\@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>,
Daniel Mack <zonque@gmail.com>,
Hans Holmberg <hans.holmberg@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Howard Cochran <cochran@lexmark.com>
Subject: Re: gpio-pxa: getting GPIOs by devicetree phandle broken
Date: Mon, 09 Feb 2015 09:02:51 +0100 [thread overview]
Message-ID: <87r3tz7bro.fsf@free.fr> (raw)
In-Reply-To: <CAAVeFu+yf6Wf6MspiDLiWwQkMwMvimNa0SpMK_yO_9X07UecEw@mail.gmail.com> (Alexandre Courbot's message of "Mon, 9 Feb 2015 15:11:23 +0900")
Alexandre Courbot <gnurou@gmail.com> writes:
> Adding Robert who reported the same thing.
>
> On Sat, Feb 7, 2015 at 6:28 AM, Tyler Hall <tylerwhall@gmail.com> wrote:
>> 1. Require child nodes in DT for each bank
>
> This would break DT compatibility.
Agreed.
>
>> 2. Refactor gpio-pxa to only register one gpiochip
>
> Sounds better, especially since this would reflect the hardware more
> accurately. One DT node should translate into one GPIO chip.
Could I know where "should translate into _one_ GPIO chip" comes from ? Is it a
specification, or is it a new rule we're creating ?
And if it's a new rule, I'd like to know what backs it up .
> problem is that I'm afraid several other drivers are doing the same
> thing and thus are now similarly broken.
That's also what I'm afraid of.
> The following is also likely to work as a workaround, but I would not
> go as far as saying this should be taken as a fix. Hans, since you
> wrote 7b8792b, could we have your input on this?
I was going to suggest the very same approach. If this one (or a similar one)
doesn't meet success, then my weekend of revert queries is not over ... and I
don't like reverts.
Cheers.
--
Robert
next prev parent reply other threads:[~2015-02-09 8:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 21:28 Tyler Hall
2015-02-09 6:11 ` Alexandre Courbot
2015-02-09 8:02 ` Robert Jarzmik [this message]
2015-02-09 9:42 ` Holmberg, Hans
2015-02-09 14:41 ` Tyler Hall
2015-02-09 17:38 ` Robert Jarzmik
2015-02-10 5:33 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3tz7bro.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=cochran@lexmark.com \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=hans.holmberg@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tylerwhall@gmail.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®