Re: [PATCH v4 0/4] perf timechart io mode

[Namhyung Kim <namhyung@kernel.org>]

Hi Stanislav,

On Tue,  8 Jul 2014 20:03:39 +0400, Stanislav Fomichev wrote:
> This patchset adds IO mode: instead of process time we record io syscalls
> and then draw timechart of writes/reads/tx/rx/polls.
>
> v6:
>   - v5 didn't actually contained 'converted consistency checks' fix, so
>     respinning the series once again with the fix folded;
>     Namhyung, can I still keep your Acked-By?

Sure thing!  For the series,

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


>     Jiri, can you please pull it?
>
> v5:
>   - converted consistency check errors to warnings so we can tolerate
>     some perf.data errors
>   - added more info to 'implement IO mode' changelog
>
> v4:
>   - another attempt for fix segfault when skipping invalid tracepoints
>   - added new patch to fix rendering in Firefox
>
> v3:
>   - fixed segfault when skipping invalid tracepoints
>   - added ms/us units support for --io-xyz time options
>   - fixed missing boxes on Firefox
>
> v2:
>   - separated start_time fix into distinct commit
>   - separated --io-xyz options into distinct commit
>   - fixed 'error' shadowing
>   - initialized variables in declaration when possible
>   - removed assert usage
>   - fprintf -> pr_err
>   - removed wrongly placed __maybe_unused
>
> Stanislav Fomichev (4):
>   perf timechart: fix rendering in Firefox
>   perf timechart: implement IO mode
>   perf timechart: conditionally update start_time on fork
>   perf timechart: add more options to IO mode
>
>  tools/perf/Documentation/perf-timechart.txt |  38 +-
>  tools/perf/builtin-timechart.c              | 693 +++++++++++++++++++++++++++-
>  tools/perf/util/svghelper.c                 | 168 +++++--
>  tools/perf/util/svghelper.h                 |   6 +-
>  4 files changed, 845 insertions(+), 60 deletions(-)