mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Pekka Enberg <penberg@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] perf ui/gtk: Separate out GTK code to a shared object (v4)
Date: Tue, 27 Aug 2013 17:03:12 +0900	[thread overview]
Message-ID: <87r4dfv9vj.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20130819151734.GB3053@ghostprotocols.net> (Arnaldo Carvalho de Melo's message of "Mon, 19 Aug 2013 12:17:34 -0300")

Hi Arnaldo,

Sorry for late reply.

On Mon, 19 Aug 2013 12:17:34 -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Aug 19, 2013 at 11:05:00AM -0300, Arnaldo Carvalho de Melo escreveu:
>> But I expected that after the first patch 'perf --gtk' would work, and
>> it doesn't.
>> 
>> Now even after I applied the whole series I don't get --gtk to work,
>> neither as a non-root nor as root :-\
>> 
>> Investigating...
>
> Somehow I expected ~/lib64/ was in the ld library path, it was not, duh,
> after I added it, and applied all three patches, it works as expected,
> so can we:
>
> 1. combine the three patches into just one so that we keep the 'perf
> report --gtk' bisectable?
>
> 2. add a patch to warn the user when '--gtk' is specified but no
>    libperf-gtk.so file is found in the loader library path?

Hmm.. makes sense.  I'll do the option 1 (include the warning).

Thanks,
Namhyung

      reply	other threads:[~2013-08-27  8:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-09  6:28 Namhyung Kim
2013-08-09  6:28 ` [PATCH 1/3] perf tools: Separate out GTK codes to libperf-gtk.so Namhyung Kim
2013-08-09  6:28 ` [PATCH 2/3] perf tools: Setup GTK browser dynamically Namhyung Kim
2013-08-09  6:28 ` [PATCH 3/3] perf tools: Run dynamic loaded GTK browser Namhyung Kim
2013-08-19 14:05 ` [PATCH 0/3] perf ui/gtk: Separate out GTK code to a shared object (v4) Arnaldo Carvalho de Melo
2013-08-19 15:17   ` Arnaldo Carvalho de Melo
2013-08-27  8:03     ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r4dfv9vj.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome