From: Peter Korsgaard <jacmet@sunsite.dk>
To: Anatolij Gustschin <agust@denx.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH] gpio: mpc8xxx: don't set IRQ_TYPE_NONE when creating irq mapping
Date: Sun, 03 Feb 2013 11:22:45 +0100 [thread overview]
Message-ID: <87r4kx66iy.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20130202202952.378af5cb@crub> (Anatolij Gustschin's message of "Sat, 2 Feb 2013 20:29:52 +0100")
>>>>> "Anatolij" == Anatolij Gustschin <agust@denx.de> writes:
Hi,
Anatolij> Thomas renamed the old set_irq_type() call to
Anatolij> irq_set_irq_type(), but this line setting the IRQ_TYPE_NONE
Anatolij> type was there before renaming. It was added by commit
Anatolij> 345e5c8a. At this time set_irq_type() checked its type
Anatolij> argument and returned 0 if the type argument didn't specify
Anatolij> some meaningful type in its type sense bits (and thus was
Anatolij> equal to IRQ_TYPE_NONE). Effectively this line was a nop and
Anatolij> I wonder what was the point of adding it.
Sorry, don't recall. It's been quite a while, and I've haven't worked on
anything mpc8xxx for a few years by now. Most likely one of the other
gpio drivers did it like this back then.
I don't remember the details, but your description makes sense so if
nobody disagrees you can have my:
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-02-03 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 12:07 Anatolij Gustschin
2013-02-02 15:11 ` Linus Walleij
2013-02-02 19:29 ` Anatolij Gustschin
2013-02-03 10:22 ` Peter Korsgaard [this message]
2013-02-04 8:10 ` Anatolij Gustschin
2013-02-04 9:13 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4kx66iy.fsf@dell.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=agust@denx.de \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®