mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Monakhov <dmonakhov@openvz.org>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC]fs: fsprivate data argument for get_block_t
Date: Fri, 07 Sep 2012 13:04:08 +0400	[thread overview]
Message-ID: <87r4qejjav.fsf@openvz.org> (raw)

Hi, I'm wonder why generic get_block_t callback has not fsprivate
argument?
Each filesystem implement it's own get_block_t callback.
Each filesystem call generic functions which use callback from
known context, but where is no good way to pass that context 
to fs_specific_get_block callback.
This result in situation where fs-specific data passed via 
inode's data (xxx_inode->cur_get_block_data)
All this means that inode's private pointer becomes implicit
serialization point even if get_block() are allowed to be called
concurrently.

I'm going to add fsprivate argument, number of generic function which
use get_block_t is not really huge, so the patch should be too big.

If some one has any objections why this shouldn't be done, please
welcome. 



                 reply	other threads:[~2012-09-07  9:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r4qejjav.fsf@openvz.org \
    --to=dmonakhov@openvz.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome