From: Andi Kleen <andi@firstfloor.org>
To: dougthompson@xmission.com
Cc: bluesmoke-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/13] EDAC i5100 new intel chipset driver
Date: Sat, 28 Jun 2008 07:07:21 +0200 [thread overview]
Message-ID: <87r6aip2pi.fsf@basil.nowhere.org> (raw)
In-Reply-To: <48652da5.s2xXeJUyQ6DrqarN%dougthompson@xmission.com> (dougthompson@xmission.com's message of "Fri, 27 Jun 2008 12:12:53 -0600")
dougthompson@xmission.com writes:
>
> 2) I have not yet tackled the de-interleaving of the
> rank/controller address space into the physical address
> space of the CPU. There is nothing fundamentally missing,
> it is just ending up to be a lot of code, and I'd rather
> keep it separate for now, esp since it doesn't work yet...
>
> 3) The code depends on a particular i5100 chip select
> to DIMM mainboard chip select mapping. This mapping
> seems obvious to me in order to support dual and single
> ranked memory, but it is not unique and DIMM labels
> could be wrong on other mainboards. There is no way
> to query this mapping that I know of.
Since there's a non negligible probability that the output
of this driver is completely misleading because of (2) and (3)
and probably (4) too [reporting the wrong DIMMs etc.]
would it be possible to add some flag to EDAC that
warns the user that the output is not fully reliable?
-Andi (who can just see people replacing the wrong DIMMs and
then blaming Linux)
next prev parent reply other threads:[~2008-06-28 5:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 18:12 dougthompson
2008-06-27 23:05 ` Andrew Morton
2008-06-30 15:08 ` Arthur Jones
2008-06-28 5:07 ` Andi Kleen [this message]
2008-06-28 6:15 ` Doug Thompson
2008-06-30 15:03 ` Arthur Jones
2008-06-30 19:58 ` Doug Thompson
2008-06-30 20:13 ` Arthur Jones
2008-06-30 15:23 ` Arthur Jones
2008-06-30 15:01 ` Arthur Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r6aip2pi.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=dougthompson@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome