From: Takashi Iwai <tiwai@suse.de>
To: "Michał Kopeć" <michal.kopec@3mdeb.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
piotr.krol@3mdeb.com, maciej.pijanowski@3mdeb.com
Subject: Re: [PATCH] ALSA: hda/core: Stop capability walk on empty capability header
Date: Tue, 03 Nov 2026 15:56:15 +0100 [thread overview]
Message-ID: <87se1ivu9c.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261102114939.2182131-1-michal.kopec@3mdeb.com>
On Mon, 02 Nov 2026 12:49:39 +0100,
Michał Kopeć wrote:
>
> From: Michal Kopec <michal.kopec@3mdeb.com>
>
> snd_hdac_bus_parse_capabilities() walks the controller's linked
> capability list starting at LLCH. On some platforms one of the entries
> reads back as all zeros. Such a header does not describe a capability,
> but the walk still treats it as one: it falls into the default case and
> reports an error, printing the raw register value instead of the
> capability ID:
>
> snd_hda_intel 0000:00:1f.3: Unknown capability 0
>
> The walk then stops anyway, because the next pointer of a zero header
> is 0, so the message is only noise.
>
> Treat an all-zero header as the end of the list, the same way a failed
> read (-1) is already handled, and log it at debug level only. Also
> print the capability ID in hex for a genuinely unknown capability,
> instead of the full header value.
>
> Fixes: 0b00a5615dc4 ("ALSA: hdac_ext: add hdac extended controller")
> Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-11-03 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 11:49 Michał Kopeć
2026-11-03 14:56 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87se1ivu9c.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=maciej.pijanowski@3mdeb.com \
--cc=michal.kopec@3mdeb.com \
--cc=perex@perex.cz \
--cc=piotr.krol@3mdeb.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®