From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49900349AE7; Fri, 30 Jan 2026 16:20:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769790026; cv=none; b=GBOiWoNVxy5HSq2zrk7D5191umMFBWR+PwOabFx2R9MPyD/vXqp4fFhFXi/gEk0oTR2P5afGnZSY1dcP5Hz1Y6bonKiWt9bo/gCHDIihJJMKhtV6WZurNEItLU38bU4HIye1JZi2Gc/NpbpTXGb66i7KVdTxShpTY7ctamXO1vI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769790026; c=relaxed/simple; bh=5xly92bMzMLkHZHjcbUH0bBICud3S1llkxSwO5zFSQ4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=GFPCX7FVC65lQl8I8hWDHyc6MXcjiRqQS3oNbo5qt8QhmQprU5qTs5Sr0IZ157m4WfZEVol8coi2ct4qfEa/q7/adTcrsXSGuVsq6qHKX8M+2vS71mJUTJdG0rjrQkwgTOTwuxgg+WyaS+UQp1JRWGIXPDIRJ/BAIp/7BhENx9U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qFvAoLrE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qFvAoLrE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 328CAC116C6; Fri, 30 Jan 2026 16:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769790025; bh=5xly92bMzMLkHZHjcbUH0bBICud3S1llkxSwO5zFSQ4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=qFvAoLrEzX3VFixqSdBDcxKh+/2NIaHvXgp6QXJ/XVe75zpRgJgXFh0wm9MYkpJG3 exncHf0mRDjc5o86zn8NuKcy8dGqpdC8jiriSLXsN8T94SMrYxlkjiAXC65Tk0rqcQ Umuk6SbPqU9oHiTOFv9ixSpmkXXKg/7OKKfC/8CeP5Bz0D4ons6ChlSlFUu0YgZPpX TLtLs4CmYN/VbzigeXhN9mTa/+ARJMXy0sDxLKwGzhzrTl1XNKi0h72UQSMjXKe/PZ Cta+H9PIDwNcZHOsLQm+e04NVOuswttseFYkwso870MJ75DEVGZXpfkaJViZbkRECx gS+b3kYySBrYA== From: Andreas Hindborg To: Gary Guo , Gary Guo , Alice Ryhl , Lorenzo Stoakes , "Liam R. Howlett" , Miguel Ojeda , Boqun Feng , =?utf-8?Q?Bj=C3=B6?= =?utf-8?Q?rn?= Roy Baron , Benno Lossin , Trevor Gross , Danilo Krummrich Cc: linux-mm@kvack.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rust: page: add volatile memory copy methods In-Reply-To: References: <20260130-page-volatile-io-v1-1-19f3d3e8f265@kernel.org> <877bszrz37.fsf@t14s.mail-host-address-is-not-set> <874io3rwl3.fsf@t14s.mail-host-address-is-not-set> <871pj7ruok.fsf@t14s.mail-host-address-is-not-set> <-9VZ2SJWMomnT82Xqo2u9cSlvCYkjqUqNxfwWMTxKmah9afzYQsZfNeCs24bgYBJVw2kTN2K3YSLYGr6naR_YA==@protonmail.internalid> Date: Fri, 30 Jan 2026 17:20:11 +0100 Message-ID: <87sebnqdhg.fsf@t14s.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Gary Guo" writes: > On Fri Jan 30, 2026 at 3:23 PM GMT, Andreas Hindborg wrote: >> "Gary Guo" writes: >> >>> On Fri Jan 30, 2026 at 2:42 PM GMT, Andreas Hindborg wrote: >>>> "Gary Guo" writes: >>>> >>>>> On Fri Jan 30, 2026 at 1:48 PM GMT, Andreas Hindborg wrote: >>>>>> "Gary Guo" writes: >>>>>> >>>>>>> On Fri Jan 30, 2026 at 12:33 PM GMT, Andreas Hindborg wrote: >>>>>>>> When copying data from buffers that are mapped to user space, or from >>>>>>>> buffers that are used for dma, it is impossible to guarantee absence of >>>>>>>> concurrent memory operations on those buffers. Copying data to/from `Page` >>>>>>>> from/to these buffers would be undefined behavior if regular memcpy >>>>>>>> operations are used. >>>>>>>> >>>>>>>> The operation can be made well defined, if the buffers that potentially >>>>>>>> observe racy operations can be said to exist outside of any Rust >>>>>>>> allocation. For this to be true, the kernel must only interact with the >>>>>>>> buffers using raw volatile reads and writes. >>>>>>>> >>>>>>>> Add methods on `Page` to read and write the contents using volatile >>>>>>>> operations. >>>>>>>> >>>>>>>> Also improve clarity by specifying additional requirements on >>>>>>>> `read_raw`/`write_raw` methods regarding concurrent operations on involved >>>>>>>> buffers. >>>>>>>> >>>>>>>> Signed-off-by: Andreas Hindborg >>>>>>>> --- >>>>>>>> rust/kernel/page.rs | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ >>>>>>>> 1 file changed, 53 insertions(+) >>>>>>>> >>>>>>>> diff --git a/rust/kernel/page.rs b/rust/kernel/page.rs >>>>>>>> index 432fc0297d4a8..6568a0d3b3baa 100644 >>>>>>>> --- a/rust/kernel/page.rs >>>>>>>> +++ b/rust/kernel/page.rs >>>>>>>> @@ -7,6 +7,7 @@ >>>>>>>> bindings, >>>>>>>> error::code::*, >>>>>>>> error::Result, >>>>>>>> + ffi::c_void, >>>>>>>> uaccess::UserSliceReader, >>>>>>>> }; >>>>>>>> use core::{ >>>>>>>> @@ -260,6 +261,8 @@ fn with_pointer_into_page( >>>>>>>> /// # Safety >>>>>>>> /// >>>>>>>> /// * Callers must ensure that `dst` is valid for writing `len` bytes. >>>>>>>> + /// * Callers must ensure that there are no other concurrent reads or writes to/from the >>>>>>>> + /// destination memory region. >>>>>>>> /// * Callers must ensure that this call does not race with a write to the same page that >>>>>>>> /// overlaps with this read. >>>>>>>> pub unsafe fn read_raw(&self, dst: *mut u8, offset: usize, len: usize) -> Result { >>>>>>>> @@ -274,6 +277,30 @@ pub unsafe fn read_raw(&self, dst: *mut u8, offset: usize, len: usize) -> Result >>>>>>>> }) >>>>>>>> } >>>>>>>> >>>>>>>> + /// Maps the page and reads from it into the given IO memory region using volatile memory >>>>>>>> + /// operations. >>>>>>>> + /// >>>>>>>> + /// This method will perform bounds checks on the page offset. If `offset .. offset+len` goes >>>>>>>> + /// outside of the page, then this call returns [`EINVAL`]. >>>>>>>> + /// >>>>>>>> + /// # Safety >>>>>>>> + /// Callers must ensure that: >>>>>>>> + /// >>>>>>>> + /// * The destination memory region is outside of any Rust memory allocation. >>>>>>>> + /// * The destination memory region is writable. >>>>>>>> + /// * This call does not race with a write to the same source page that overlaps with this read. >>>>>>>> + pub unsafe fn read_raw_toio(&self, dst: *mut u8, offset: usize, len: usize) -> Result { >>>>>>>> + self.with_pointer_into_page(offset, len, move |src| { >>>>>>>> + // SAFETY: If `with_pointer_into_page` calls into this closure, then >>>>>>>> + // it has performed a bounds check and guarantees that `src` is >>>>>>>> + // valid for `len` bytes. >>>>>>>> + // >>>>>>>> + // There caller guarantees that there is no data race at the source. >>>>>>>> + unsafe { bindings::memcpy_toio(dst.cast::(), src.cast::(), len) }; >>>>>>> >>>>>>> I feel that this should be a generic utility that integrates with our IO infra >>>>>>> that allows you to copy/from IO to a slice. >>>>>> >>>>>> While that might also be useful, for my particular use case I am copying >>>>>> between two pages. One is mapped from user space, the other one is >>>>>> allocated by a driver. No slices involved. Pasting for reference [1]: >>>>> >>>>> Then what you need is a byte-wise atomic memcpy, not memcpy_{from,to}io. >>>> >>>> Can you elaborate on how you get to this requirement? >>> >>> Memory that is possibly mapped into userspace is still normal memory, it is not >>> I/O. I/O accessors (and IO memcpy) are specifically used for MMIO, and you >>> should not be using them for userspace memory. >>> >>> For memory that can be mutated from userspace you can just treat them as a >>> potentially concurrent accessor hence all accesses should be using atomic. When >>> tearing is acceptable, byte-wise atomic is sufficient. >> >> I would treat them the same as DMA regions and MMIO regions. As these >> regions are outside of any Rust allocation, if we never make references >> to them and if we only operate on them with volatile operations, >> behavior of the copy operations like these are defined, as far as I >> understand. > > I don't find the argument about these being outside Rust allocation very useful. > Apart from MMIO, I view all other types of memory still within purview of the > abstract machine. >From the discussions we had on reading memory that may incur racy writes, what I picked up is that these are OK under the conditions that the regions are outside of any Rust allocation (whatever that means), and they are only ever accessed by volatile operations. That is why I think it is useful to consider these allocations outside of any Rust allocation. A similar argument to the one I am trying to make here was made in `UserSliceReader::read_raw`, which delegates to a C function that (after mapping and setup) ends up in an assembly implemented memcpy. > >> >> In the last discussions we had on this, the conclusion was to use >> `volatile_copy_memory` whenever that is available, or write a volatile >> copy function in assembly. >> >> Using memcpy_{from,to}io is the latter solution. These functions are >> simply volatile memcpy implemented in assembly. >> >> There is nothing special about MMIO. These functions are name as they >> are because they are useful for MMIO. > > No. MMIO are really special. A few architectures require them to be accessed > completely differently compared to normal memory. We also have things like > INDIRECT_IOMEM. memory_{from,to}io are special as they use MMIO accessor such as > readb to perform access on the __iomem pointer. They should not be mixed with > normal memory. They must be treated as if they're from a completely separate > address space. > > Normal memory vs DMA vs MMIO are all distinct, and this is demonstrated by the > different types of barriers needed to order things correctly for each type of > memory region. > > Userspace-mapped memory (that is also mapped in the kernel space, not __user) is > the least special one out of these. They could practically share all atomic infra > available for the kernel, hence the suggestion of using byte-wise atomic memcpy. I see. I did not consider this. At any rate, I still don't understand why I need an atomic copy function, or why I need a byte-wise copy function. A volatile copy function should be fine, no? And what is the exact problem in using memcpy_{from,to}io. Looking at it, I would end up writing something similar if I wrote a copy function myself. If it is the wrong function to use, can you point at a fitting funciton? Best regards, Andreas Hindborg