From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F7B833A006 for ; Mon, 1 Sep 2025 13:51:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756734705; cv=none; b=LFCWZvHmwRZk03RfAvMBeKkjPIwTstUq5qun1UGeXnoi/458VT4/z46mXx8C9bVjObityKB9nghSh99Um1JFr4NXPxKcZ3fwY65KCr5VecwOzQi4hXMtpdlhSAOPehla1QpODs6a59mjcHqLxKHO84Brudi5fhJ7q1CBKCSu6Jc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756734705; c=relaxed/simple; bh=YoY8NfgtkUyKVH/wCj70FqKjQOg08SB6VhoLRtwjubc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=knSC0XOn7O7xvmTJ//mZNrmhsnwIuSeydOpEXnxXbPnIYbx2jjsXT+BnHVS8q/qJJ6Z2pEboDfnWNcQcqFL+LPT9eqMTVjGma44hSCehMX6pcMxJCqpArYv1vdw/T6DZ8FB0TVMxrnlRiBWhbyFm0Ff4Kf76/pNC5+vDd7wdVZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Jj6nH69F; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Jj6nH69F" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756734703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rNZv88G48kGiSTnEe1GdQJytPUc11wW2bIHAr97ppkA=; b=Jj6nH69FGOXVX8BPjs4OffGuxoHlql6a8z7o/iYwgVjW7o7Q7JN0DvQ10o+l1l+S/iFfN7 dFErF8ETdvtaK6JYWtjKRFDZjHjjidqGtt1vbeisUiQk/fRY6Xy26yeEQ5SUFxLRpaY8FY /kvAgu2MzFCvq0MSxw6RwGMccm8rvgU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-26-WCxqRayXNW-SrVVHtX9Tgw-1; Mon, 01 Sep 2025 09:51:42 -0400 X-MC-Unique: WCxqRayXNW-SrVVHtX9Tgw-1 X-Mimecast-MFC-AGG-ID: WCxqRayXNW-SrVVHtX9Tgw_1756734701 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45b7c4c738cso16341935e9.0 for ; Mon, 01 Sep 2025 06:51:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756734701; x=1757339501; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rNZv88G48kGiSTnEe1GdQJytPUc11wW2bIHAr97ppkA=; b=GNOO8A5gfON3KTCQRqKlzYmqtyMZpMdNlLpMFSWbbyLRKxsQmUfK14eUv4VsIe5v8Z jihZezdS9Ive5SlHCKGAqLMyqcFD0c9+/taZDRQ3e+vpWBJ+24lVYGOCfuCxQrDrS707 2XG6cedUG9XwAR0QcmfI5nH/Aq0pmkcFxER76Ae6LbkrMwfodiUihgvFpDIv3B9V1G1C bbnKYUxmwO3MKE79TA5vVvTxkm0bf7Fjlkd6EfG5ItSGFpzcUcD8gQCuRelUjzzuSUXQ 3Vjq69Sq5CgbwyhUZZBYLBQG2wu2DpN1W05GXmbWiE3ze/VJX7HZSZ1W91dL+yNI1wRE FaRw== X-Forwarded-Encrypted: i=1; AJvYcCU106ZRu8aCd2BIztldUMzmBLZCuZ8zt3RO8HxbNAI91FQV2BWBVIfb794oVLgGOsGy0C8PYKk9VAypoPU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxp3UN/6pUuEd1cOImKqpZPqjBj4A++x9ybXWoxCv5WCywv/tgg lrNJx0g1JTUKvrQaD3gD8aU7rlcXWjTCQwaCUKcSKlBRRHKR9yiU7crmHRoldX9qDYl3FW7N/21 if900CaJLHIlnGpTUejqIhO+dCjpbq9Rz+EjZU6JmNBeX5gwWqFgLRbWo2Gr8dvSQVQ== X-Gm-Gg: ASbGncsNwlvHlJVcK+pW/Jq0to51/XChVXS55Do2uGGoCmyQfeNxMT6COf5QvkzHO17 N8ak1CNw6phS+6oOdu4ZpnKvwCkyE/Cak9h9Eur8KTox4rbFmMFnnLAx3m7DRd649R6R158WZeL j/6DNNf9Y99ftlKWH/9a+by7lbhodEr46iJFHKiBnBZSDyiHtPoQMU5TxdQL2ekMYtd303XTbia OULOqgY+mW1abxbcwaxfB1AzF0zmIZ+dbLv+awHMpwQlSZp7MvgujGUu18zFCj7uvk8sypwJLGW CQIrx+vUo5SCxA5eT/0ICOow3yl0pXAI2r5arLCdSVz9vYeYHyEwNS8PGfBjOU1T7w== X-Received: by 2002:a05:600c:1f08:b0:45b:765a:a8ff with SMTP id 5b1f17b1804b1-45b855333e7mr70347025e9.11.1756734700961; Mon, 01 Sep 2025 06:51:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGZG5ym0+uvSyAKRRTSIKOXFShFsslOTmvomyIF3wBHiI22R5u0tBS4cfbprR0gPfxuAplifw== X-Received: by 2002:a05:600c:1f08:b0:45b:765a:a8ff with SMTP id 5b1f17b1804b1-45b855333e7mr70346775e9.11.1756734700463; Mon, 01 Sep 2025 06:51:40 -0700 (PDT) Received: from localhost ([89.128.88.54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b7e68c83asm167467245e9.20.2025.09.01.06.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Sep 2025 06:51:39 -0700 (PDT) From: Javier Martinez Canillas To: Marcus Folkesson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Marcus Folkesson Subject: Re: [PATCH v2 0/6] drm/st7571-i2c: add support for grayscale xrgb8888 In-Reply-To: <20250721-st7571-format-v2-0-159f4134098c@gmail.com> References: <20250721-st7571-format-v2-0-159f4134098c@gmail.com> Date: Mon, 01 Sep 2025 15:51:38 +0200 Message-ID: <87seh6ffh1.fsf@minerva.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Marcus Folkesson writes: Hello Marcus, > The goal with this series is to add support for 2bit grayscale with > the xrgb8888 pixel format for the st7571 display controller. > > The first patch only corrects a comment of the pixel format. > > The next four patches adds support for inverting pixels. This is > necessary as the connected display may or may not use the "right" (0 => > black, 1 => white) pixel format expected by the supported formats > (R1/R2/XRGB8888). > > The fifth patch adds a helper function (drm_fb_xrgb8888_to_gray2) to > convert xrgb8888 to gray2. > > The last path adds support for gray2 in the st7571 driver. > Compare the mono [1] and the gray2 [2] variants of our penguin. > > [1] https://www.marcusfolkesson.se/gray2.png > [2] https://www.marcusfolkesson.se/xrgb8888.png > > Signed-off-by: Marcus Folkesson > --- > Changes in v2: > - Do not share code between _to_mono() and _to_gray2() > - Correct formatting (remove "|") in the dt bindings > - Implement support for inverting pixels for st7567 > - Link to v1: https://lore.kernel.org/r/20250714-st7571-format-v1-0-a27e5112baff@gmail.com > > --- > Marcus Folkesson (6): > drm/st7571-i2c: correct pixel data format description > dt-bindings: display: sitronix,st7571: add optional inverted property > dt-bindings: display: sitronix,st7567: add optional inverted property > drm/st7571-i2c: add support for inverted pixel format > drm/format-helper: introduce drm_fb_xrgb8888_to_gray2() > drm/st7571-i2c: add support for 2bit grayscale for XRGB8888 > When applying I noticed that patch #5 had the following warning [0], but I fixed it locally before pushing to drm-misc (drm-misc-next). Thanks! [0]: CHECK: Alignment should match open parenthesis #86: FILE: drivers/gpu/drm/drm_format_helper.c:1415: +void drm_fb_xrgb8888_to_gray2(struct iosys_map *dst, const unsigned int *dst_pitch, + const struct iosys_map *src, const struct drm_framebuffer *fb, CHECK: Alignment should match open parenthesis #153: FILE: include/drm/drm_format_helper.h:140: +void drm_fb_xrgb8888_to_gray2(struct iosys_map *dst, const unsigned int *dst_pitch, + const struct iosys_map *src, const struct drm_framebuffer *fb, total: 0 errors, 0 warnings, 2 checks, 125 lines checked -- Best regards, Javier Martinez Canillas Core Platforms Red Hat