From: Jonathan Corbet <corbet@lwn.net>
To: Nikolay Borisov <nik.borisov@suse.com>,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
kernel@collabora.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] docs: document linked lists
Date: Thu, 17 Jul 2025 13:54:01 -0600 [thread overview]
Message-ID: <87seiua90m.fsf@trenco.lwn.net> (raw)
In-Reply-To: <0b85f378-221b-408e-865b-b4eab675a351@suse.com>
Nikolay Borisov <nik.borisov@suse.com> writes:
> Nit: I think it's unnecessary to repeat the initilization in code since
> you've already explicitly mentioned you continue form State 2 of the
> previous example, so the only salient information is the additional
> list_bulk_move_tail call.
[...]
I have a nit of my own: now that the kerneldoc for the hlist functions
is here (it naturally moved with the rest), it would be nice to have
some sort of mention, even if just a paragraph saying why hlists exist
and when one might want to use them.
That said, I have gone ahead and applied this; we've put Nicolas through
enough rounds, and I'd like to get this in for the 6.17 merge window.
The nits can be addressed at leisure with follow-on patches.
Thanks,
jon
prev parent reply other threads:[~2025-07-17 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 8:14 Nicolas Frattaroli
2025-07-17 10:27 ` Nikolay Borisov
2025-07-17 19:54 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87seiua90m.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=kernel@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=nik.borisov@suse.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®