From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 377952135D0 for ; Tue, 14 Jan 2025 23:19:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736896778; cv=none; b=H9C3ujVOpZb+3C8431AzbRKlfwU7gW8PdhCN2a/wJRcxJQxBctX8bnh7LdqFdkgWmPVI6XiI7kTeq9+mf/P4AH4U5s28yYLuaGvWJpEGlxpWzBFuDOpkckoUkPGXUUFEW0y3+owUU7cv4ERwshGHwm/n3otYgbLYDv8GoAQ8uRA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736896778; c=relaxed/simple; bh=axuci0v4DSfoyYdgpAq3h3WkhqdNxR3WSCaJMFOOO0Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=uCTTXLr8KyBnLCAQIMBoV8rPOXQV93ZEvTxK74vmf6GU1ovEFkkPmhbKv/P2oL85o/RJ764Wv1wgm39UJPzstBRCYW/4TIdvvqGeLldWzuIzOdgIvfHBFeN2LuMlk6IJ8Cf5GSPvLJHBrtrwrX+8LuuJLd/JVX/BvvxXmgNj61M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ShNJIVOP; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ShNJIVOP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736896775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vEH78C4VpeJFY/2kdzUK4Z+Gvb2+CGFwdUUzW6v1srY=; b=ShNJIVOPrWP4Kx6TDQV3Hq4o/5rVKgXVHX6FlMC8bn0WD9ynD05gcoY0uwGm7NY0k8M6aw wPuAcatSje74rrIgkfQdRxq9w5MMKZ9EkVGBS2LjSusKHSN2064rID1smSiBFVqy8deC3x 7foY6qygZVotEE9tSmdtkZ76q6aqdCs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-yszcXg4zOMyybEj7iUNnBA-1; Tue, 14 Jan 2025 18:19:33 -0500 X-MC-Unique: yszcXg4zOMyybEj7iUNnBA-1 X-Mimecast-MFC-AGG-ID: yszcXg4zOMyybEj7iUNnBA Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-436379713baso28524765e9.2 for ; Tue, 14 Jan 2025 15:19:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736896772; x=1737501572; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vEH78C4VpeJFY/2kdzUK4Z+Gvb2+CGFwdUUzW6v1srY=; b=Q5A0WDxtf+OOYv7x5DSR1sktjNs66QAjPHCecSROBW5Gbw/OD/7HPbksm1zNHrlriy 4D1Vgg5AIuF2x0X53YAz7f98XpqfKZcMGN8p87ZoA7Y1BP4J5+tRtU5gdKg6zMYnus4p 3zPo62d8H58zg7RXZIQSQbUFnmQGs2t1hwD4evGvU+73rJq5ASfC6rBEtTL3yVozNX+W IxOyGot/Kzo2kwkxRcheq8eXsfTZYwrbw5fMpHGi1/6NIFE9OiCjVBZcy5HQ8V/R1xdK QlDuDDXsxbJXlYnwpq+I911BciVhMxWQ/h5yC9DnNif/cN3Gdl1Ioq2RRlg/GLQrYMWN 3jFw== X-Forwarded-Encrypted: i=1; AJvYcCVdIRgV+xSUAU4+7zK6ETbfn4PjgUdGLrXiBlA3v9iAIPYdb7iPD7kC9Atoa65m+D2NBbLdSbExfPYB4QU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz37FeNSMso7Hs3XLx4kI1GwBwt6QD66Xd1G1fgkufZRKLuGJDE cMRu1WuCBMZ4xAj72SbK28+6phoFN3uAKkq/BMdF4Nv9yNcu3NcuiqawXXvz9bN9czX28Ae4RS+ NVe7Dsme23gowSozFeef/VdcfdrIzz6HLEj5hheWYoFbAO/mvAek7JncAXzQdWw== X-Gm-Gg: ASbGnctgp6mU2MokSjaFGlichsRFoQ6bf4qnZE6sMAWjjrqzF9HiiNbzO++8cxRj9fR Ajt9Z5gZLIlg6CPblc5ecpI/qUSljOkILrBJBsPCgKbtR8PrwQIFhLSlDOwHlunsbeFO01gh+Zi TrwKIyAsT4z17YNsQxeCBPUhAn9SLvXITH73f62OCPzG5UJ1Fs3L2fv4//rSSqyxpQURU5xR32z NVCLuenZ3yLeXRy6mSHhXVpX3aTbYS55Url+VmJx93GUZh4XJcNBAnugsdYDscUybRd+lHoOGCR ekePjS8HKmVjxzGsvYnXQDnx2k4GU8ztXk38kMU= X-Received: by 2002:a05:600c:3505:b0:434:a7b6:10e9 with SMTP id 5b1f17b1804b1-436e26a9045mr259532825e9.17.1736896772608; Tue, 14 Jan 2025 15:19:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHWz6ammZEBbT/nuGvY3Rz/ahY09xIAHiCyZ9AgrNGDygX+MT179mirdv9eYOPWOGlEdRYU/A== X-Received: by 2002:a05:600c:3505:b0:434:a7b6:10e9 with SMTP id 5b1f17b1804b1-436e26a9045mr259532695e9.17.1736896772231; Tue, 14 Jan 2025 15:19:32 -0800 (PST) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c7499b28sm2526785e9.8.2025.01.14.15.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 15:19:30 -0800 (PST) From: Javier Martinez Canillas To: John Keeping Cc: John Keeping , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] drm/ssd130x: ensure ssd132x pitch is correct In-Reply-To: <20250113152752.3369731-4-jkeeping@inmusicbrands.com> References: <20250113152752.3369731-1-jkeeping@inmusicbrands.com> <20250113152752.3369731-4-jkeeping@inmusicbrands.com> Date: Wed, 15 Jan 2025 00:19:28 +0100 Message-ID: <87seplvv9b.fsf@minerva.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain John Keeping writes: > The bounding rectangle is adjusted to ensure it aligns to > SSD132X_SEGMENT_WIDTH, which may adjust the pitch. Calcuate the pitch Calculate > after alighting the left and right edge. > aligning > Signed-off-by: John Keeping > --- > drivers/gpu/drm/solomon/ssd130x.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c > index 64f1123080996..38f31c3624062 100644 > --- a/drivers/gpu/drm/solomon/ssd130x.c > +++ b/drivers/gpu/drm/solomon/ssd130x.c > @@ -1037,7 +1037,7 @@ static int ssd132x_fb_blit_rect(struct drm_framebuffer *fb, > struct drm_format_conv_state *fmtcnv_state) > { > struct ssd130x_device *ssd130x = drm_to_ssd130x(fb->dev); > - unsigned int dst_pitch = drm_rect_width(rect); > + unsigned int dst_pitch; > struct iosys_map dst; > int ret = 0; > > @@ -1046,6 +1046,8 @@ static int ssd132x_fb_blit_rect(struct drm_framebuffer *fb, > rect->x2 = min_t(unsigned int, round_up(rect->x2, SSD132X_SEGMENT_WIDTH), > ssd130x->width); > > + dst_pitch = drm_rect_width(rect); > + > ret = drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE); > if (ret) > return ret; > -- > 2.47.1 > Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat