From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 638A4E7D0A2 for ; Thu, 21 Sep 2023 17:50:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbjIURuP (ORCPT ); Thu, 21 Sep 2023 13:50:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229881AbjIURt5 (ORCPT ); Thu, 21 Sep 2023 13:49:57 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B50162724 for ; Thu, 21 Sep 2023 10:03:09 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1CE6921DC8; Thu, 21 Sep 2023 07:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1695281594; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CtSTnaLnaJEKj1j/kHsXGQg1xrJm7Dcrziia39euvc8=; b=sXR5FTPpsdCvHSV+3Wzc4Y6SiatA8kkX6IiI7WOIyCqhMeHhr3QuVOdEG0zlOOSd2zZ7n3 c+saM0Mglh7dZdSU7E4tk3Ul50x4Go/KUcT3XBxYOApwavRGjYT+aqPPonG17IR8mnEC3M rovvX2DwbFkS4NrbK1FLv2Fa8bL24Qc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1695281594; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CtSTnaLnaJEKj1j/kHsXGQg1xrJm7Dcrziia39euvc8=; b=xKpK1wTn4RIo7c8vmiuZaUc+CgsXh2MO8LeeV4LA5c/ObebGrnW4lWO5cubah1FYxWeU9g XErNPssYEffDlsAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E854713513; Thu, 21 Sep 2023 07:33:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tMmyN7nxC2VpegAAMHmgww (envelope-from ); Thu, 21 Sep 2023 07:33:13 +0000 Date: Thu, 21 Sep 2023 09:33:13 +0200 Message-ID: <87sf78t1za.wl-tiwai@suse.de> From: Takashi Iwai To: Abelardo Ricart Cc: linux-kernel@vger.kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org Subject: Re: [PATCHv3] ALSA: hda/realtek: Add quirk for ASUS ROG G533Q In-Reply-To: <2436e7f2-b986-4dda-9d4d-0f73845c1ffc@gmail.com> References: <2436e7f2-b986-4dda-9d4d-0f73845c1ffc@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Sep 2023 09:22:57 +0200, Abelardo Ricart wrote: > > The same quirk applied to the ASUS G533Z is also applicable to the ASUS > G533Q (of which I am an owner and have thus tested). > > Signed-off-by: Abelardo Ricart Unfortunately it's still a problem; tabs are converted to 4 spaces. I recommend you to try sending to yourself locally and verify whether it works before resubmitting v4. thanks, Takashi > --- > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index dc7b7a407638..fdc3560ad951 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -9649,6 +9649,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { >      SND_PCI_QUIRK(0x1043, 0x1493, "ASUS GV601V", ALC285_FIXUP_ASUS_HEADSET_MIC), >      SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), >      SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V", ALC285_FIXUP_ASUS_HEADSET_MIC), > +    SND_PCI_QUIRK(0x1043, 0x1602, "ASUS ROG Strix G15 (G533Q)", ALC285_FIXUP_ASUS_G533Z_PINS), >      SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK), >      SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR", ALC287_FIXUP_CS35L41_I2C_2), >      SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401), >