From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12DD4C001DE for ; Tue, 25 Jul 2023 10:06:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232323AbjGYKGe (ORCPT ); Tue, 25 Jul 2023 06:06:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233331AbjGYKGN (ORCPT ); Tue, 25 Jul 2023 06:06:13 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFE9930E0 for ; Tue, 25 Jul 2023 03:05:42 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9359B1F74D; Tue, 25 Jul 2023 10:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690279540; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ffIVx/0irLZ6QeL71Ci+G/BkmbsNoisvAqsp8tTW3Dc=; b=kLqHOoKW5NmQwYDantmrqvXJmW9Uq1Spb/ZdrAyxHXulidqW/zNSNTdpictKuCRL2hHhUF pZ7sE7bErPMEPsgh2VtZHdlzrjjHDJeo+nI/wm1DOLrXOiVPCbxFMcOs7odYHr18DZbOPZ lSV6xhSm23EkAHwPaWL8S871gV47/CY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690279540; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ffIVx/0irLZ6QeL71Ci+G/BkmbsNoisvAqsp8tTW3Dc=; b=1Og+a5iQVu1ykX6tlxy5davGFwJnqgaXQ9zxBkyoCZKXOzWlhjZ1RlujAnuCLdsWHZdYzn HQw2b0SqfTo3khBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5243D13342; Tue, 25 Jul 2023 10:05:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2JvSEnSev2SIbwAAMHmgww (envelope-from ); Tue, 25 Jul 2023 10:05:40 +0000 Date: Tue, 25 Jul 2023 12:05:39 +0200 Message-ID: <87sf9ctifg.wl-tiwai@suse.de> From: Takashi Iwai To: Robert Lee Cc: vkoul@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: compress: add opus codec define In-Reply-To: <20230725093005.3499455-1-lerobert@google.com> References: <20230725093005.3499455-1-lerobert@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jul 2023 11:30:05 +0200, Robert Lee wrote: > > Add to support decode Opus codec in Ogg container. > > Signed-off-by: Robert Lee The change makes sense only when it's really used. So usually it's better to put into a series that actually implements its usage. thanks, Takashi > --- > include/uapi/sound/compress_params.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h > index ddc77322d571..bac5797bcb02 100644 > --- a/include/uapi/sound/compress_params.h > +++ b/include/uapi/sound/compress_params.h > @@ -43,7 +43,8 @@ > #define SND_AUDIOCODEC_BESPOKE ((__u32) 0x0000000E) > #define SND_AUDIOCODEC_ALAC ((__u32) 0x0000000F) > #define SND_AUDIOCODEC_APE ((__u32) 0x00000010) > -#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_APE > +#define SND_AUDIOCODEC_OPUS ((__u32) 0x00000011) > +#define SND_AUDIOCODEC_MAX SND_AUDIOCODEC_OPUS > > /* > * Profile and modes are listed with bit masks. This allows for a > -- > 2.41.0.487.g6d72f3e995-goog >