From: Kalle Valo <kvalo@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild@lists.01.org, Anilkumar Kolli <akolli@codeaurora.org>,
lkp@intel.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: drivers/net/wireless/ath/ath11k/qmi.c:1891 ath11k_qmi_assign_target_mem_chunk() error: uninitialized symbol 'ret'.
Date: Fri, 28 Jan 2022 09:24:28 +0200 [thread overview]
Message-ID: <87sft8cogj.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <202201272025.7AWXB5T7-lkp@intel.com> (Dan Carpenter's message of "Fri, 28 Jan 2022 10:07:04 +0300")
(adding ath11k list)
Dan Carpenter <dan.carpenter@oracle.com> writes:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 0280e3c58f92b2fe0e8fbbdf8d386449168de4a8
> commit: 6ac04bdc5edb418787ab2040b1f922c23464c750 ath11k: Use reserved host DDR addresses from DT for PCI devices
> config: microblaze-randconfig-m031-20220127 (https://download.01.org/0day-ci/archive/20220127/202201272025.7AWXB5T7-lkp@intel.com/config)
> compiler: microblaze-linux-gcc (GCC) 11.2.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> New smatch warnings:
> drivers/net/wireless/ath/ath11k/qmi.c:1891 ath11k_qmi_assign_target_mem_chunk() error: uninitialized symbol 'ret'.
>
> Old smatch warnings:
> drivers/net/wireless/ath/ath11k/qmi.c:2161 ath11k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
>
> vim +/ret +1891 drivers/net/wireless/ath/ath11k/qmi.c
>
> 6eb6ea51382873 Govind Singh 2020-08-14 1876 static int ath11k_qmi_assign_target_mem_chunk(struct ath11k_base *ab)
> d5c65159f28953 Kalle Valo 2019-11-23 1877 {
> 6ac04bdc5edb41 Anilkumar Kolli 2021-12-14 1878 struct device *dev = ab->dev;
> 6ac04bdc5edb41 Anilkumar Kolli 2021-12-14 1879 struct device_node *hremote_node = NULL;
> 6ac04bdc5edb41 Anilkumar Kolli 2021-12-14 1880 struct resource res;
> 6ac04bdc5edb41 Anilkumar Kolli 2021-12-14 1881 u32 host_ddr_sz;
> 6ac04bdc5edb41 Anilkumar Kolli 2021-12-14 1882 int i, idx, ret;
> d5c65159f28953 Kalle Valo 2019-11-23 1883
> d5c65159f28953 Kalle Valo 2019-11-23 1884 for (i = 0, idx = 0; i < ab->qmi.mem_seg_count; i++) {
> d5c65159f28953 Kalle Valo 2019-11-23 1885 switch (ab->qmi.target_mem[i].type) {
> 6ac04bdc5edb41 Anilkumar Kolli 2021-12-14 1886 case HOST_DDR_REGION_TYPE:
> 6ac04bdc5edb41 Anilkumar Kolli 2021-12-14 1887 hremote_node = of_parse_phandle(dev->of_node, "memory-region", 0);
> 6ac04bdc5edb41 Anilkumar Kolli 2021-12-14 1888 if (!hremote_node) {
> 6ac04bdc5edb41 Anilkumar Kolli 2021-12-14 1889 ath11k_dbg(ab, ATH11K_DBG_QMI,
> 6ac04bdc5edb41 Anilkumar Kolli 2021-12-14 1890 "qmi fail to get hremote_node\n");
> 6ac04bdc5edb41 Anilkumar Kolli 2021-12-14 @1891 return ret;
>
> "ret" not set.
Anil, can you send a patch to fix this?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-01-28 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 7:07 Dan Carpenter
2022-01-28 7:24 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sft8cogj.fsf@tynnyri.adurom.net \
--to=kvalo@kernel.org \
--cc=akolli@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®