From: Jonathan Corbet <corbet@lwn.net>
To: Akira Yokosawa <akiyks@gmail.com>,
Joel Colledge <joel.colledge@linbit.com>
Cc: Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
drbd-dev@lists.linbit.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] docs: admin-guide/blockdev: Remove digraph of node-states
Date: Mon, 29 Nov 2021 14:39:33 -0700 [thread overview]
Message-ID: <87sfvesktm.fsf@meer.lwn.net> (raw)
In-Reply-To: <7df04f45-8746-e666-1a9d-a998f1ab1f91@gmail.com>
Akira Yokosawa <akiyks@gmail.com> writes:
> While node-states-8.dot has two digraphs, the dot(1) command can
> not properly handle multiple graphs in a DOT file and the
> kernel-doc page at
>
> https://www.kernel.org/doc/html/latest/admin-guide/blockdev/drbd/figures.html
>
> fails to render the graphs.
>
> It turned out that the digraph of node_states can be removed.
>
> Quote from Joel's reflection:
>
> On reflection, the digraph node_states can be removed entirely.
> It is too basic to contain any useful information. In addition
> it references "ioctl_set_state". The ioctl configuration
> interface for DRBD has long been removed. In fact, it was never
> in the upstream version of DRBD.
>
> Remove node_states and rename the DOT file peer_states-8.dot.
>
> Suggested-by: Joel Colledge <joel.colledge@linbit.com>
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> Cc: Philipp Reisner <philipp.reisner@linbit.com>
> Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
Applied, thanks.
jon
prev parent reply other threads:[~2021-11-29 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 4:11 Akira Yokosawa
2021-11-26 7:16 ` Joel Colledge
2021-11-29 21:39 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfvesktm.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=akiyks@gmail.com \
--cc=drbd-dev@lists.linbit.com \
--cc=joel.colledge@linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®