From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE303C433C1 for ; Fri, 26 Mar 2021 09:46:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 942C961A3F for ; Fri, 26 Mar 2021 09:46:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbhCZJqa (ORCPT ); Fri, 26 Mar 2021 05:46:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58098 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230016AbhCZJp4 (ORCPT ); Fri, 26 Mar 2021 05:45:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616751955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XG6h7spL153kovHcC5yY8ljihAEwgHllcDY8/MH1Mnw=; b=eNNBsbcjNu/AaFkiPl7YpYBdRiEoafBoFy+D7GTo94lIjKSb14qsI1taRenyVeUIsyA0QH 46Wzgs7uXJ6dbCoATI8zz8W+Pt7P97P19X98K5a5kT7zpE9Z4oq2ATvyr+I1KceZezLige sLJezCfkgORqHyU2COpbgM/3P/72jAI= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-v7Yg9ZwJMa2Y35Li--bdAA-1; Fri, 26 Mar 2021 05:45:53 -0400 X-MC-Unique: v7Yg9ZwJMa2Y35Li--bdAA-1 Received: by mail-ej1-f69.google.com with SMTP id e7so3848099ejx.5 for ; Fri, 26 Mar 2021 02:45:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=XG6h7spL153kovHcC5yY8ljihAEwgHllcDY8/MH1Mnw=; b=nnL0qM2cQIcS2TwgYq+xgG8rXwOf5KtpSWB/jCQZpzQppb5VC5ZFepzz0pvRHbLmFe rMWglpDQJHH18YdbuZLnzinXVmd8cN00pyImqn2OnpuO4vEiC8MtNs1/UCLtjXnDrzTY tBlAPHNJYOy/NtawVBVMdd7w8zIJRQgA7pGLQIegLc2x2WvpFAcO/tTEzg7yqTV7kCWK w2lMR+g+pbg2FZY8z2ZvAKWXArQrtchMO3U3kiBH8gStz/IUhv/h65AUiTrTGd4/rhsK swynKMxmUYNbKM1aKRlchYu6iX//tElqIvCCW5GSCp/I7maGvY9VJcAjo+XlVeP7yaFI 2RAw== X-Gm-Message-State: AOAM530LL3f/xhoV6oduczTTaV8qeSXHDqT03EWVo5cki30UZebrd+ZI VACOwWSgp6P/uLXEw8UoOIcwVzEeHWXocDb1O1hemrWlG6I8n4Yl6Ie+Ovfp+TPU0lwo2dKS5r6 tJN/nMLZPiQ+91Bzwd7m6lop5oWDHtI1NNCnlD7WAeKDRxf2CKiyYF6OhCP9N107NzAaogstOv5 +R X-Received: by 2002:a17:907:7651:: with SMTP id kj17mr14296326ejc.127.1616751952848; Fri, 26 Mar 2021 02:45:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyE0k8X5SPvpAMb7ckZxoBBS75iJ7ZWfhqplxSPtWKx+vvCBL/3M4zUeuYeVDlKoAevFSdZew== X-Received: by 2002:a17:907:7651:: with SMTP id kj17mr14296294ejc.127.1616751952545; Fri, 26 Mar 2021 02:45:52 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id va9sm728410ejb.31.2021.03.26.02.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 02:45:51 -0700 (PDT) From: Vitaly Kuznetsov To: Dongli Zhang , kvm@vger.kernel.org, x86@kernel.org Cc: pbonzini@redhat.com, seanjc@google.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] KVM: x86: remove unused declaration of kvm_write_tsc() In-Reply-To: <20210326070334.12310-1-dongli.zhang@oracle.com> References: <20210326070334.12310-1-dongli.zhang@oracle.com> Date: Fri, 26 Mar 2021 10:45:50 +0100 Message-ID: <87sg4ickoh.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dongli Zhang writes: > The kvm_write_tsc() was not used since commit 0c899c25d754 ("KVM: x86: do > not attempt TSC synchronization on guest writes"). Remove its unused > declaration. It's not just not used, it's not present. Let me try to rephrase the commit message a bit: " Commit 0c899c25d754 ("KVM: x86: do not attempt TSC synchronization on guest writes") renamed kvm_write_tsc() to kvm_synchronize_tsc() and made it 'static'. Remove the leftover declaration from x86.h Fixes: 0c899c25d754 ("KVM: x86: do not attempt TSC synchronization on guest writes") " The subject line should probably also get adjusted like "KVM: x86: remove dangling declaration of kvm_write_tsc()" > > Signed-off-by: Dongli Zhang > --- > arch/x86/kvm/x86.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h > index 39eb04887141..9035e34aa156 100644 > --- a/arch/x86/kvm/x86.h > +++ b/arch/x86/kvm/x86.h > @@ -250,7 +250,6 @@ static inline bool kvm_vcpu_latch_init(struct kvm_vcpu *vcpu) > void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock, int sec_hi_ofs); > void kvm_inject_realmode_interrupt(struct kvm_vcpu *vcpu, int irq, int inc_eip); > > -void kvm_write_tsc(struct kvm_vcpu *vcpu, struct msr_data *msr); > u64 get_kvmclock_ns(struct kvm *kvm); > > int kvm_read_guest_virt(struct kvm_vcpu *vcpu, -- Vitaly