mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org, luto@kernel.org
Subject: Re: [RFC][PATCH 3/3] x86/entry, ORC: Teach objtool/unwind_orc about stack irq swizzles
Date: Fri, 08 May 2020 14:26:32 +0200	[thread overview]
Message-ID: <87sggak3yf.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200508101209.GY5298@hirez.programming.kicks-ass.net>

Peter Zijlstra <peterz@infradead.org> writes:

> On Thu, May 07, 2020 at 11:24:49PM +0200, Thomas Gleixner wrote:
>> But over our IRC conversation I came up with a 3rd variant:
>> 
>>   For most of the vectors the indirect call overhead is just noise, so
>>   we can run them through the ASM switcher, but for the resched IPI
>>   we can just use a separate direct call stub in ASM.
>
> Are we sure the rat-poison crap is noise for all the other system
> vectors? I suppose it is for most since they'll do indirect calls
> themselves anyway, right?

We have different categories:

 1) Uninteresting

    SPURIOUS_APIC_VECTOR, ERROR_APIC_VECTOR, THERMAL_APIC_VECTOR,
    THRESHOLD_APIC_VECTOR, REBOOT_VECTOR, DEFERRED_ERROR_VECTOR

 2) Indirect call poisoned

    LOCAL_TIMER_VECTOR
    X86_PLATFORM_IPI_VECTOR
    IRQ_WORK_VECTOR
    HYPERV_STIMER0_VECTOR
    HYPERVISOR_CALLBACK_VECTOR
    POSTED_INTERRUPT_WAKEUP_VECTOR.
    CALL_FUNCTION_VECTOR
    CALL_FUNCTION_SINGLE_VECTOR
    
 3) Quick

    RESCHEDULE_VECTOR

    POSTED_INTR_VECTOR
    POSTED_INTR_NESTED_VECTOR

        These two postit ones are weird because they are both empty and
        just increment different irq counts.

    HYPERV_REENLIGHTENMENT_VECTOR

        schedules delayed work, i,e. arms a timer which should be
        straight forward, but does it matter?

 4) Others

    UV_BAU_MESSAGE - The TLB flushes are probably more expensive than
                     ratpoutine

Hmm?

Thanks,

        tglx

  reply	other threads:[~2020-05-08 12:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 16:10 [RFC][PATCH 0/3] objtool vs irqstack swizzles Peter Zijlstra
2020-05-07 16:10 ` [RFC][PATCH 1/3] x86/entry: Collapse the 3 IRQ stack instances into a single macro Peter Zijlstra
2020-05-07 16:10 ` [RFC][PATCH 2/3] x86/entry: Provide ASM_INSTR_{BEGIN,END} Peter Zijlstra
2020-05-07 16:10 ` [RFC][PATCH 3/3] x86/entry, ORC: Teach objtool/unwind_orc about stack irq swizzles Peter Zijlstra
2020-05-07 17:38   ` Peter Zijlstra
2020-05-07 18:30     ` Josh Poimboeuf
2020-05-07 21:24       ` Thomas Gleixner
2020-05-08 10:12         ` Peter Zijlstra
2020-05-08 12:26           ` Thomas Gleixner [this message]
2020-05-08 12:40             ` Peter Zijlstra
2020-05-08 12:44             ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sggak3yf.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®