From: Kalle Valo <kvalo@codeaurora.org>
To: Chris Chiu <chiu@endlessm.com>
Cc: YueHaibing <yuehaibing@huawei.com>,
Jes Sorensen <Jes.Sorensen@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
David Miller <davem@davemloft.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask'
Date: Wed, 23 Oct 2019 13:16:43 +0300 [thread overview]
Message-ID: <87sgnjeph0.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <CAB4CAwek7u3_U9T_314P7qK2o7ReKQ0EVvYTkyzrORZjhdSRnA@mail.gmail.com> (Chris Chiu's message of "Wed, 23 Oct 2019 18:10:50 +0800")
Chris Chiu <chiu@endlessm.com> writes:
> On Wed, Oct 23, 2019 at 3:54 PM YueHaibing <yuehaibing@huawei.com> wrote:
>>
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4484:6:
>> warning: variable rate_mask set but not used [-Wunused-but-set-variable]
>>
>> It is never used since commit a9bb0b515778 ("rtl8xxxu: Improve
>> TX performance of RTL8723BU on rtl8xxxu driver")
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
> Singed-off-by: Chris Chiu <chiu@endlessm.com>
In the future please use Reviewed-by:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
Signed-off-by is supposed to be used when you are sending a patch and
Acked-by is used by the driver maintainer, in this case Jes.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-10-23 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 7:53 YueHaibing
2019-10-23 10:10 ` Chris Chiu
2019-10-23 10:16 ` Kalle Valo [this message]
2019-10-24 5:49 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgnjeph0.fsf@tynnyri.adurom.net \
--to=kvalo@codeaurora.org \
--cc=Jes.Sorensen@gmail.com \
--cc=chiu@endlessm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome