From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933717AbcLAQKz (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Dec 2016 11:10:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44118 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933647AbcLAQKx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Dec 2016 11:10:53 -0500
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: x86@kernel.org
Cc: devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v2] x86/hyperv: Handle unknown NMIs on one CPU when unknown_nmi_panic
References: <20161201144550.14966-1-vkuznets@redhat.com>
Date: Thu, 01 Dec 2016 17:10:49 +0100
In-Reply-To: <20161201144550.14966-1-vkuznets@redhat.com> (Vitaly Kuznetsov's
        message of "Thu, 1 Dec 2016 15:45:50 +0100")
Message-ID: <87shq7d3zq.fsf@vitty.brq.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 01 Dec 2016 16:10:52 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Vitaly Kuznetsov <vkuznets@redhat.com> writes:

[snip]

>  static void __init ms_hyperv_init_platform(void)
>  {
>  	/*
> @@ -183,6 +204,9 @@ static void __init ms_hyperv_init_platform(void)
>  		pr_info("HyperV: LAPIC Timer Frequency: %#x\n",
>  			lapic_timer_frequency);
>  	}
> +
> +	register_nmi_handler(NMI_LOCAL, hv_nmi_unknown, NMI_FLAG_FIRST,
> +			     "hv_nmi_unknown");

This should probably be NMI_UNKNOWN instead of NMI_LOCAL. While it works
regardless and we don't have other NMIs on Hyper-V VMs (or do we?) I
think it would be better to do v3.

Sorry for the inconvenience.

-- 
  Vitaly