From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755465AbcI2Ppm (ORCPT ); Thu, 29 Sep 2016 11:45:42 -0400 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:48335 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755341AbcI2Ppf (ORCPT ); Thu, 29 Sep 2016 11:45:35 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Thu, 29 Sep 2016 17:45:32 +0200 X-ME-IP: 109.222.115.228 From: Robert Jarzmik To: Baoyou Xie Cc: daniel@zonque.org, haojian.zhuang@gmail.com, vinod.koul@intel.com, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: Re: [PATCH] dmaengine: pxa_dma: remove unused function References: <1475154561-12327-1-git-send-email-baoyou.xie@linaro.org> X-URL: http://belgarath.falguerolles.org/ Date: Thu, 29 Sep 2016 17:45:22 +0200 In-Reply-To: <1475154561-12327-1-git-send-email-baoyou.xie@linaro.org> (Baoyou Xie's message of "Thu, 29 Sep 2016 21:09:21 +0800") Message-ID: <87shsiaewd.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Baoyou Xie writes: > We get 1 warning when building kernel with W=1: > drivers/dma/pxa_dma.c:1525:5: warning: no previous prototype for 'pxad_toggle_reserved_channel' [-Wmissing-prototypes] > > In fact, this function is called by no one, so this patch removes it. > > Signed-off-by: Baoyou Xie Okay, yet I'd rather have a revert of commit c91134d91944 ("dmaengine: pxa_dma: add support for legacy transition") , with the commit message saying: The conversion of the pxa architecture is now finished for all drivers, so this functions has fullfilled its purpose and can now be removed. I have a similar patch in my internal tree, but yours can very well go in, as long as it is a revert with a statement explaining why it is necessary now and not before. Cheers. -- Robert