From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753318AbcIMB0D convert rfc822-to-8bit (ORCPT ); Mon, 12 Sep 2016 21:26:03 -0400 Received: from ozlabs.org ([103.22.144.67]:34887 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751967AbcIMB0B (ORCPT ); Mon, 12 Sep 2016 21:26:01 -0400 From: Michael Ellerman To: Christophe Leroy , Colin King , Benjamin Herrenschmidt , Paul Mackerras , Scott Wood , Kevin Hao , Joonsoo Kim , linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/32: add missing \n at end of printk warning message In-Reply-To: References: <20160912101224.24877-1-colin.king@canonical.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 13 Sep 2016 11:25:58 +1000 Message-ID: <87sht4pp3t.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christophe Leroy writes: > Le 12/09/2016 à 12:12, Colin King a écrit : >> diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c >> index 448685f..b532dd9 100644 >> --- a/arch/powerpc/mm/init_32.c >> +++ b/arch/powerpc/mm/init_32.c >> @@ -137,7 +137,7 @@ void __init MMU_init(void) >> if (memblock.memory.cnt > 1) { >> #ifndef CONFIG_WII >> memblock_enforce_memory_limit(memblock.memory.regions[0].size); >> - printk(KERN_WARNING "Only using first contiguous memory region"); >> + printk(KERN_WARNING "Only using first contiguous memory region\n"); > > This line was already 81 characters long. It is now 83. That doesn't really bother me. > I would suggest to use pr_warn() instead in order to shorten the line. But I do like pr_warn(), it's less shouty. I'll fix it up when I apply it. cheers