From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030379AbcHEG5u (ORCPT ); Fri, 5 Aug 2016 02:57:50 -0400 Received: from ozlabs.org ([103.22.144.67]:48670 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965170AbcHEG5t (ORCPT ); Fri, 5 Aug 2016 02:57:49 -0400 From: Michael Ellerman To: Alessio Igor Bogani , Scott Wood Cc: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , LKML , linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org, antoine.blangy@c-s.fr, segher@kernel.crashing.org Subject: Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic() In-Reply-To: References: <20160802080705.69A9F1A2394@localhost.localdomain> <1470282813.25630.242.camel@buserror.net> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 05 Aug 2016 16:57:46 +1000 Message-ID: <87shujitxx.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alessio Igor Bogani writes: > On 4 August 2016 at 05:53, Scott Wood wrote: >> On Tue, 2016-08-02 at 10:07 +0200, Christophe Leroy wrote: >>> commit 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic() >>> based on copy_tofrom_user()") introduced a bug when destination >>> address is odd and initial csum is not null >>> >>> In that (rare) case the initial csum value has to be rotated one byte >>> as well as the resulting value is >>> >>> This patch also fixes related comments >>> >>> Fixes: 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic() >>> based on copy_tofrom_user()") >>> Cc: stable@vger.kernel.org >>> >>> Signed-off-by: Christophe Leroy >>> --- >>> v2: updated comments as suggested by Segher >>> >>> arch/powerpc/lib/checksum_32.S | 7 ++++--- >>> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> Alessio, can you confirm whether this fixes the problem you reported? > > No unfortunately. Thanks for testing. I've dropped the patch for now, send me a new one that works. cheers