From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755836AbcFGUa4 (ORCPT ); Tue, 7 Jun 2016 16:30:56 -0400 Received: from anholt.net ([50.246.234.109]:51919 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755607AbcFGUaz (ORCPT ); Tue, 7 Jun 2016 16:30:55 -0400 From: Eric Anholt To: Ben Dooks , linux-kernel@lists.codethink.co.uk Cc: Ben Dooks , Ulf Hansson , Alexander Aring , Kevin Hilman , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: bcm2835: remove unused __packet In-Reply-To: <1465321773-21519-1-git-send-email-ben.dooks@codethink.co.uk> References: <1465321773-21519-1-git-send-email-ben.dooks@codethink.co.uk> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 07 Jun 2016 13:30:41 -0700 Message-ID: <87shwo68su.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Ben Dooks writes: > The driver defines a variable called __packet but then never > uses it, and does not export it for others to use either. Fix > the warning about undeclared variable by removing it. > > drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static? Reviewed-by: Eric Anholt PM folks: I'd be happy to see this go through your trees, but either way is fine with me. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXVy7yAAoJELXWKTbR/J7oSxMQAJmh6AlG844FJ0n34oyS0g4H BsnQ7T7BZHs8VghcO7FrQMyBoJ3FLYnba6zHbaofrSryTw8/pYsAViDF2m/37bBu wP2LjuOzcbCRRd7URCkA6QFpXPNSQlZbuFf9Z9JrUB2yhKt8YJ0QQ1GhoFPJ3uU6 eI8YeU7jge9eWZanpWxJ8FbO1WlxQlHCso0d2aj1WiNV1ZCK/vv99yy+MoD5rHJe kG9qhYkMkBSqKSyleY5Khush+sBMMhB1uh1wWj7Qttq8QokNR/6dZ1HV5RRhdSz3 0FhA0NKJcwPCnAHMu/T9vHM/kqY7adyYuyHJxlwgyTPLlIXXQa3dA+bQd1zdQi2W aFXLWrLJEO5Y0G2/GdpmNk67dpYlhzvgu3Xtp8ZXiETVsaOfn2Kfg6Tb/6IrQ075 vrm9M7PXuwf4cUJPt7//TJDSTm7eOpkEwShD+7cyLze/wGpW/ZPoMhlxdpokLo20 vfsnIcb207R3YX92wjj/lhbpMfAkOVDRjLtNLUsh3xa2cZ4xITuze1i5tGTSLgEI uo79Vsw6bCEnEBmWiB5s0wfIwS1tM+Ndu8bzYq56c56f2GBKCu21uM2w9FlEXpDp 1fAwDHvygxlTQ6YpnJjAjgMCeBCddAGlwDcUkOzwKQn6Wp0QetVaN+3QG4d/hY3s af+InUuMviWzFbpvVz1y =MC0Q -----END PGP SIGNATURE----- --=-=-=--