From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932560AbcELPcs (ORCPT ); Thu, 12 May 2016 11:32:48 -0400 Received: from down.free-electrons.com ([37.187.137.238]:58266 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932444AbcELPcq (ORCPT ); Thu, 12 May 2016 11:32:46 -0400 From: Gregory CLEMENT To: Arnd Bergmann Cc: "David S. Miller" , Paul Gortmaker , Marcin Wojtas , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: mvneta: bm: fix dependencies again References: <1462997636-1049487-1-git-send-email-arnd@arndb.de> Date: Thu, 12 May 2016 17:32:34 +0200 In-Reply-To: <1462997636-1049487-1-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Wed, 11 May 2016 22:13:23 +0200") Message-ID: <87shxnmgvh.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On mer., mai 11 2016, Arnd Bergmann wrote: > I tried to fix this before, but my previous fix was incomplete > and we can still get the same link error in randconfig builds > because of the way that Kconfig treats the > > default y if MVNETA=y && MVNETA_BM_ENABLE > > line that does not actually trigger when MVNETA_BM_ENABLE=m, > unlike I intended. > Changing the line to use MVNETA_BM_ENABLE!=n however has > the desired effect and hopefully makes all configurations > work as expected. > > Signed-off-by: Arnd Bergmann > Fixes: 019ded3aa7c9 ("net: mvneta: bm: clarify dependencies") It looks ok for me. Acked-by: Gregory CLEMENT Thanks, Gregory > --- > drivers/net/ethernet/marvell/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig > index b5c6d42daa12..2664827ddecd 100644 > --- a/drivers/net/ethernet/marvell/Kconfig > +++ b/drivers/net/ethernet/marvell/Kconfig > @@ -68,7 +68,7 @@ config MVNETA > > config MVNETA_BM > tristate > - default y if MVNETA=y && MVNETA_BM_ENABLE > + default y if MVNETA=y && MVNETA_BM_ENABLE!=n > default MVNETA_BM_ENABLE > select HWBM > help > -- > 2.7.0 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com