From: Eric Anholt <eric@anholt.net>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@baylibre.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: bcm2835: Add the auxiliary clocks to the device tree.
Date: Mon, 28 Sep 2015 12:26:37 -0700 [thread overview]
Message-ID: <87si5ymjki.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <5600BAC3.70506@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 801 bytes --]
Stephen Warren <swarren@wwwdotorg.org> writes:
> On 09/10/2015 03:22 PM, Eric Anholt wrote:
>> These will be used for enabling UART1, SPI1, and SPI2.
>
>> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
>
>> + aux_clocks: aux-clocks@0x7e215004 {
>> + compatible = "brcm,bcm2835-aux-clock";
>> + #clock-cells = <1>;
>> + reg = <0x7e215004 0x4>;
>
> Actually, I take back the ack on this patch. This HW module has two
> registers. The reg property should include both of those registers so
> that if SW needs to start using the other register at some time in the
> future, the entire set of registers is already represented in DT.
If I changed it to "reg = <0x7e215000 0x8>" and use a #define for the
clock register offset in patch 2/3, would I then have your ack?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2015-09-28 19:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 22:22 BCM2835 auxiliary peripheral clocks Eric Anholt
2015-09-10 22:22 ` [PATCH 1/3] clk: bcm2835: Add bindings for the auxiliary peripheral clock gates Eric Anholt
2015-09-10 22:22 ` [PATCH 2/3] clk: bcm2835: Add a driver " Eric Anholt
2015-09-11 10:24 ` Martin Sperl
2015-09-22 2:11 ` Stephen Warren
2015-10-02 0:19 ` Stephen Boyd
2015-09-10 22:22 ` [PATCH 3/3] ARM: bcm2835: Add the auxiliary clocks to the device tree Eric Anholt
2015-09-22 2:12 ` Stephen Warren
2015-09-22 2:19 ` Stephen Warren
2015-09-28 19:26 ` Eric Anholt [this message]
2015-09-28 19:49 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87si5ymjki.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome