From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752589AbbE0GQ1 (ORCPT ); Wed, 27 May 2015 02:16:27 -0400 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:19389 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752559AbbE0GQZ (ORCPT ); Wed, 27 May 2015 02:16:25 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 27 May 2015 08:16:24 +0200 X-ME-IP: 109.222.71.104 From: Robert Jarzmik To: Paul Bolle Cc: Vinod Koul , Jonathan Corbet , Daniel Mack , Haojian Zhuang , dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 3/5] dmaengine: pxa: add pxa dmaengine driver References: <1432589362-23241-1-git-send-email-robert.jarzmik@free.fr> <1432589362-23241-3-git-send-email-robert.jarzmik@free.fr> <1432625314.27695.200.camel@x220> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 27 May 2015 08:15:00 +0200 In-Reply-To: <1432625314.27695.200.camel@x220> (Paul Bolle's message of "Tue, 26 May 2015 09:28:34 +0200") Message-ID: <87siaizguz.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul Bolle writes: > Vinod already applied this, so my remarks, if valid, should probably be > handled in a follow up patch. > >> +module_platform_driver(pxad_driver); > > (The series starting at https://lkml.org/lkml/2015/5/10/131 would allow > to use builtin_platform_driver() for built-in only code.) I won't be that way for forever, see next comment. >> +MODULE_DESCRIPTION("Marvell PXA Peripheral DMA Driver"); >> +MODULE_AUTHOR("Robert Jarzmik "); >> +MODULE_LICENSE("GPL v2"); > > This patch added a bool Kconfig symbol. So pxa_dma.c will never be part > of a module. > Its code contains a few module specific macros. Was it actually intended for > PXA_DMA to be tristate? It is designed to be a module, and in the "end" it will be a module. What is important to understand is the 3 phases which are going to happen : - phase 1 : state after this is merged pxa_dma must be builtin, for legacy support (see pxad_toggle_reserved_channel()). - phase 2 : slowly, all the pxa drivers are converted to dmaengine - phase 3 : after full conversion, the patch "add support for legacy transition" is reverted. There pxa_dma will become modular, and the tristate will appear. In conclusion, it cannot be a module yet, but it will in the future. Cheers. -- Robert